Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for Rust (rust.py)#3146

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240203112042_new_pr_rust
Feb 11, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for Rust (rust.py)#3146
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240203112042_new_pr_rust

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 3, 2024

(created using eb --new-pr)

  • no use of EB_Rust in easyconfigs or blocks

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 6, 2024

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS Rust-1.70.0-GCCcore-12.3.0.eb
  • SUCCESS Rust-1.65.0-GCCcore-12.2.0.eb
  • SUCCESS Rust-1.65.0-GCCcore-11.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node093.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/714dab8812cd008187e49271e713d627 for a full test report.

edit: tested with --rpath

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 11, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Rust-1.52.1-GCCcore-10.3.0.eb
  • SUCCESS Rust-1.75.0-GCCcore-12.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3557.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/6c4ee6bcbff56219df004876049275bc for a full test report.

@boegel boegel merged commit 4bd8097 into easybuilders:5.0.x Feb 11, 2024
@branfosj branfosj deleted the 20240203112042_new_pr_rust branch February 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants