Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for MXNet (mxnet.py)#3206

Merged
boegel merged 2 commits intoeasybuilders:5.0.xfrom
branfosj:20240210091418_new_pr_mxnet
Mar 4, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for MXNet (mxnet.py)#3206
boegel merged 2 commits intoeasybuilders:5.0.xfrom
branfosj:20240210091418_new_pr_mxnet

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 10, 2024 •
edited
Loading

(created using eb --new-pr)

  • no use of EB_MXNet in easyconfigs or blocks

@branfosj branfosj added this to the 5.0 milestone Feb 10, 2024
@branfosj branfosj mentioned this pull request Feb 10, 2024
Closed
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 10, 2024 •
edited
Loading

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/e4ddddb61082504fad34eca6ecaa9e50 for a full test report.

edit

== FAILED: Installation ended unsuccessfully: `/rds/projects/2017/branfosj-rse/easybuild/EL8-ice/software/Python/3.10.4-GCCcore-11.3.0/bin/python -m pip check` failed:               
mxnet 1.9.1 has requirement graphviz<0.9.0,>=0.8.1, but you have graphviz 0.20.1.

Failure is not related to this PR and the easyconfig does not enable the installation of the R extension...

bartoldeman
bartoldeman approved these changes Feb 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

boegel
boegel approved these changes Mar 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit bd8999d into easybuilders:5.0.x Mar 4, 2024
@branfosj branfosj deleted the 20240210091418_new_pr_mxnet branch March 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees

No one assigned

Labels

change EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @bartoldeman