Skip to content

enable use_pip for extensions that are installed along with Python#3221

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240211200336_new_pr_python
Feb 12, 2024
Merged

enable use_pip for extensions that are installed along with Python#3221
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240211200336_new_pr_python

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 11, 2024 •
edited by boegel
Loading

(created using eb --new-pr)

ERROR: Installation of Python-3.11.5-GCCcore-13.2.0.eb failed: "When using ensurepip to install pip (requested by install_pip=True) you must set 'use_pip=True' for the pip & setuptools extensions. Found 'use_pip=False' (maybe by default) for setuptools."

@branfosj branfosj added this to the 5.0 milestone Feb 11, 2024
@branfosj branfosj mentioned this pull request Feb 11, 2024
Closed
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 11, 2024

Though I am unsure why easybuilders/easybuild-easyconfigs#19777 (comment) was fine.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2024

Though I am unsure why easybuilders/easybuild-easyconfigs#19777 (comment) was fine.

'use_pip': True was removed from exts_default_options in the Python easyconfigs in easybuilders/easybuild-easyconfigs#19265, which was only merged 4 days ago, that explains it.

@boegel boegel changed the title use_pip=True is default in EB5 enable use_pip for extensions that are installed along with Python Feb 12, 2024
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 12, 2024

Though I am unsure why easybuilders/easybuild-easyconfigs#19777 (comment) was fine.

'use_pip': True was removed from exts_default_options in the Python easyconfigs in easybuilders/easybuild-easyconfigs#19265, which was only merged 4 days ago, that explains it.

But the comment I linked to was a build yesterday evening using the 5.0.x branch.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2024

Though I am unsure why easybuilders/easybuild-easyconfigs#19777 (comment) was fine.

'use_pip': True was removed from exts_default_options in the Python easyconfigs in easybuilders/easybuild-easyconfigs#19265, which was only merged 4 days ago, that explains it.

But the comment I linked to was a build yesterday evening using the 5.0.x branch.

That's using Python easyconfigs from develop, where 'use_pip': True is still present.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr3221 Python-2.7.18-GCCcore-10.3.0-bare.eb Python-2.7.18-GCCcore-11.2.0-bare.eb Python-2.7.18-GCCcore-11.2.0.eb Python-2.7.18-GCCcore-11.3.0-bare.eb Python-2.7.18-GCCcore-12.2.0-bare.eb Python-3.10.4-GCCcore-11.3.0-bare.eb Python-3.10.4-GCCcore-11.3.0.eb Python-3.10.8-GCCcore-12.2.0-bare.eb Python-3.10.8-GCCcore-12.2.0.eb Python-3.11.3-GCCcore-12.3.0.eb Python-3.11.5-GCCcore-13.2.0.eb Python-3.9.5-GCCcore-10.3.0-bare.eb Python-3.9.5-GCCcore-10.3.0.eb Python-3.9.6-GCCcore-11.2.0-bare.eb Python-3.9.6-GCCcore-11.2.0.eb"
EB_BRANCH=5.0.x

@boegelbot
Copy link
Copy Markdown

boegelbot commented Feb 12, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3221 EB_ARGS="--installpath /tmp/$USER/pr3221 Python-2.7.18-GCCcore-10.3.0-bare.eb Python-2.7.18-GCCcore-11.2.0-bare.eb Python-2.7.18-GCCcore-11.2.0.eb Python-2.7.18-GCCcore-11.3.0-bare.eb Python-2.7.18-GCCcore-12.2.0-bare.eb Python-3.10.4-GCCcore-11.3.0-bare.eb Python-3.10.4-GCCcore-11.3.0.eb Python-3.10.8-GCCcore-12.2.0-bare.eb Python-3.10.8-GCCcore-12.2.0.eb Python-3.11.3-GCCcore-12.3.0.eb Python-3.11.5-GCCcore-13.2.0.eb Python-3.9.5-GCCcore-10.3.0-bare.eb Python-3.9.5-GCCcore-10.3.0.eb Python-3.9.6-GCCcore-11.2.0-bare.eb Python-3.9.6-GCCcore-11.2.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3221 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3598

Test results coming soon (I hope)...

Details

- notification for comment with ID 1938408064 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-3.11.5-GCCcore-13.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3557.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/d17ab7c11cf3b752a1e93a9b43dbefb0 for a full test report.

@boegelbot
Copy link
Copy Markdown

boegelbot commented Feb 12, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.18-GCCcore-10.3.0-bare.eb
  • SUCCESS Python-2.7.18-GCCcore-11.2.0-bare.eb
  • SUCCESS Python-2.7.18-GCCcore-11.2.0.eb
  • SUCCESS Python-2.7.18-GCCcore-11.3.0-bare.eb
  • SUCCESS Python-2.7.18-GCCcore-12.2.0-bare.eb
  • SUCCESS Python-3.10.4-GCCcore-11.3.0-bare.eb
  • SUCCESS Python-3.10.4-GCCcore-11.3.0.eb
  • SUCCESS Python-3.10.8-GCCcore-12.2.0-bare.eb
  • SUCCESS Python-3.10.8-GCCcore-12.2.0.eb
  • SUCCESS Python-3.11.3-GCCcore-12.3.0.eb
  • SUCCESS Python-3.11.5-GCCcore-13.2.0.eb
  • SUCCESS Python-3.9.5-GCCcore-10.3.0-bare.eb
  • SUCCESS Python-3.9.5-GCCcore-10.3.0.eb
  • SUCCESS Python-3.9.6-GCCcore-11.2.0-bare.eb
  • SUCCESS Python-3.9.6-GCCcore-11.2.0.eb

Build succeeded for 15 out of 15 (15 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/9310af740ee05dd119bf866358988c16 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 12, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.18-GCCcore-10.3.0-bare.eb
  • SUCCESS Python-2.7.18-GCCcore-11.2.0-bare.eb
  • SUCCESS Python-2.7.18-GCCcore-11.2.0.eb
  • SUCCESS Python-2.7.18-GCCcore-11.3.0-bare.eb
  • SUCCESS Python-2.7.18-GCCcore-12.2.0-bare.eb
  • SUCCESS Python-3.10.4-GCCcore-11.3.0-bare.eb
  • SUCCESS Python-3.10.4-GCCcore-11.3.0.eb
  • SUCCESS Python-3.10.8-GCCcore-12.2.0-bare.eb
  • SUCCESS Python-3.10.8-GCCcore-12.2.0.eb
  • SUCCESS Python-3.11.3-GCCcore-12.3.0.eb
  • SUCCESS Python-3.11.5-GCCcore-13.2.0.eb
  • SUCCESS Python-3.9.5-GCCcore-10.3.0-bare.eb
  • SUCCESS Python-3.9.5-GCCcore-10.3.0.eb
  • SUCCESS Python-3.9.6-GCCcore-11.2.0-bare.eb
  • SUCCESS Python-3.9.6-GCCcore-11.2.0.eb

Build succeeded for 15 out of 15 (15 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/779f765bf752ee0ea01d3396744dcac0 for a full test report.

boegel
boegel approved these changes Feb 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 252ec7b into easybuilders:5.0.x Feb 12, 2024
@branfosj branfosj deleted the 20240211200336_new_pr_python branch February 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot