Skip to content

fix support for recent Intel tools (icc, ifort, imkl, impi)#325

Merged
boegel merged 12 commits intoeasybuilders:developfrom
boegel:new_intel_tools
Dec 12, 2013
Merged

fix support for recent Intel tools (icc, ifort, imkl, impi)#325
boegel merged 12 commits intoeasybuilders:developfrom
boegel:new_intel_tools

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 11, 2013

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to mpi.mod etc? is it redundant?

otherwise reviewed, good piece of work! If you can, document a bit more the *_NAME_2012* consts.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgeorgatos: This is only a sanity check, it's by no means meant to be exhaustive.

Besides that: nothing really changed here, the mpi_mods stuff was factored out higher up, so checking for include/mpi.mod is still part of the sanity check for all MPI versions.
For v4.x however, we now also check for mpi_base.mod, mpi_constants.mod, and mpi_sizeofs.mod include files, which weren't there in older Intel MPI version (3.x).

So, that part is actually an enhancement for installing old Intel MPI versions (which I had to do a while ago).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 12, 2013

Fully tested using the easyconfigs in easybuilders/easybuild-easyconfigs#609, works like a charm, so merging in.

Thanks for the review @fgeorgatos!

boegel added a commit that referenced this pull request Dec 12, 2013
fix support for recent Intel tools (icc, ifort, imkl, impi)
@boegel boegel merged commit e44f1e2 into easybuilders:develop Dec 12, 2013
@boegel boegel deleted the new_intel_tools branch December 12, 2013 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants