Skip to content

allow overriding testinstall in PyTorch easyconfigs#3250

Merged
branfosj merged 2 commits intoeasybuilders:developfrom
Flamefire:20240307094940_new_pr_pytorch
Mar 21, 2024
Merged

allow overriding testinstall in PyTorch easyconfigs#3250
branfosj merged 2 commits intoeasybuilders:developfrom
Flamefire:20240307094940_new_pr_pytorch

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@boegel boegel changed the title allow overriding testinstall in PyTorch ECs allow overriding testinstall in PyTorch easyconfigs + use --verbose option when using pip Mar 13, 2024
@boegel boegel added this to the 4.x milestone Mar 13, 2024
branfosj
branfosj previously approved these changes Mar 18, 2024
@branfosj
Copy link
Copy Markdown
Member

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS PyTorch-2.1.2-foss-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/513a17876a5fc9e8fc7575f73b263288 for a full test report.

@Flamefire Flamefire changed the title allow overriding testinstall in PyTorch easyconfigs + use --verbose option when using pip allow overriding testinstall in PyTorch easyconfigs Mar 18, 2024
@Flamefire
Copy link
Copy Markdown
Contributor Author

@boegel The pip change was unintentional. I removed that part of the change as this is already done via the PythonPackage option (extra_options).

The test reports are not invalidated by that because if it worked with that change it will also work without that change (given it worked before)

@branfosj branfosj modified the milestones: 4.x, release after 4.9.0 Mar 21, 2024
@branfosj branfosj merged commit 9b0d5f5 into easybuilders:develop Mar 21, 2024
@Flamefire Flamefire deleted the 20240307094940_new_pr_pytorch branch March 21, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants