Skip to content

new easyblock for AEDT#3281

Merged
Micket merged 11 commits intoeasybuilders:developfrom
appolloford:20240405130242_new_pr_ansysem
Apr 18, 2024
Merged

new easyblock for AEDT#3281
Micket merged 11 commits intoeasybuilders:developfrom
appolloford:20240405130242_new_pr_ansysem

Conversation

@appolloford
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@Micket Micket added the new label Apr 5, 2024
@appolloford appolloford changed the title new easyblock for ansysem new easyblock for aedt Apr 10, 2024
@appolloford appolloford marked this pull request as draft April 12, 2024 14:57
@appolloford appolloford marked this pull request as ready for review April 12, 2024 19:18
@Micket Micket added this to the release after 4.9.1 milestone Apr 18, 2024
Comment thread easybuild/easyblocks/a/aedt.py Outdated
Comment thread easybuild/easyblocks/a/aedt.py Outdated
with open(os.path.join(self.installdir, self.subdir, "VerifyOS.bash"), "w") as f:
f.write("")

# Set LC_ALL and LANG for runtime
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please just expand on this comment as to why, i.e. "becuase AEDT is extremely picky and blablablabla"

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket enabled auto-merge April 18, 2024 13:50
@Micket Micket merged commit 3d5d42c into easybuilders:develop Apr 18, 2024
@boegel boegel changed the title new easyblock for aedt new easyblock for AEDT Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants