Skip to content

use run_shell_cmd in custom easyblock for Maple#3286

Merged
boegel merged 5 commits intoeasybuilders:5.0.xfrom
branfosj:20240406104122_new_pr_maple
Apr 9, 2024
Merged

use run_shell_cmd in custom easyblock for Maple#3286
boegel merged 5 commits intoeasybuilders:5.0.xfrom
branfosj:20240406104122_new_pr_maple

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Apr 6, 2024 •
edited by boegel
Loading

@branfosj branfosj mentioned this pull request Apr 6, 2024
Closed
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Apr 6, 2024
@branfosj branfosj added this to the 5.0 milestone Apr 6, 2024
boegel
boegel requested changes Apr 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also escape ? in question patterns + fix language selection pattern

Comment thread easybuild/easyblocks/m/maple.py Outdated
Comment thread easybuild/easyblocks/m/maple.py Outdated
Comment thread easybuild/easyblocks/m/maple.py Outdated
Comment thread easybuild/easyblocks/m/maple.py Outdated
Comment thread easybuild/easyblocks/m/maple.py Outdated
Comment thread easybuild/easyblocks/m/maple.py Outdated
boegel
boegel requested changes Apr 6, 2024
View reviewed changes
Comment thread easybuild/easyblocks/m/maple.py Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2024

Currently fails for Maple-2022.1.eb with:

== 2024-04-06 13:43:52,308 run.py:439 DEBUG No match found in question/wait patterns at end of stdout: b'Language Selection\n\nPlease select the installation language\n[1] English - English\n[2] Japanese - \xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e\nPlease choose an option [1] : ----------------------------------------------------------------------------\nWelcome to the Maple Setup Wizard.\n\n----------------------------------------------------------------------------\nPlease read the following License Agreement. You must accept the terms of this \nagreement before continuing with the installation.\n\nPress [Enter] to continue:MAPLESOFT SOFTWARE LICENSE AGREEMENT\nTHE FOLLOWING TERMS AND CONDITIONS APPLY TO ALL SOFTWARE PRODUCTS LICENSED BY \nMAPLESOFT, A DIVISION OF WATERLOO MAPLE INC. (\xe2\x80\x9cMAPLESOFT\xe2\x80\x9d), TO YOU (\xe2\x80\x9cYOU\xe2\x80\x9d OR \n\xe2\x80\x9cYOUR\xe2\x80\x9d, WHEN USED IN REFERENCE TO YOU) AS SET OUT IN THE ORDER CONFIRMATION \nISSUED TO YOU BY MAPLESOFT OR BY A MAPLESOFT AUTHORIZED RESELLER, BEING ONE OF \nTHE PARTNERS LISTED ON MAPLESOFT\xe2\x80\x99S WEBSITE AT HTTP://WWW.MAPLESOFT.COM/CONTACT.\n\nNOTICE: THIS IS A CONTRACT. BEFORE YOU COMPLETE THE INSTALLATION AND '
== 2024-04-06 13:43:52,532 build_log.py:171 ERROR EasyBuild encountered an error (at easybuild/eb5/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): No matching questions found for current command output, giving up after 150 seconds! (at easybuild/eb5/easybuild-framework/easybuild/tools/run.py:445 in run_shell_cmd)

Installing of Maple-2022.1.eb works fine with run_cmd_qa.

This looks like partial output, so perhaps we're hitting a bug in run_shell_cmd here, or we're not patient enough.

@boegel boegel mentioned this pull request Apr 6, 2024
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2024

easybuilders/easybuild-framework#4504 definitely fixes a problem, but it may not be sufficient for the interactive installation command for Maple, it seems...

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 9, 2024

I had to fix a question pattern too, it assumed that the question for a desktop shortcut was on a single line, while there actually empty lines in between, so I had to tweak the pattern a bit (see 99ba832)

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 9, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Maple-2022.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3563.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/1b99fbb139761ac828a287d4ed1478c6 for a full test report.

@boegel boegel merged commit e7ff61c into easybuilders:5.0.x Apr 9, 2024
@branfosj branfosj deleted the 20240406104122_new_pr_maple branch April 9, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel