Skip to content

add libjpeg-turbo to include dir for torchvision easyblock#3322

Merged
boegel merged 4 commits intoeasybuilders:developfrom
smoors:20240507222011_new_pr_torchvision
Jun 7, 2024
Merged

add libjpeg-turbo to include dir for torchvision easyblock#3322
boegel merged 4 commits intoeasybuilders:developfrom
smoors:20240507222011_new_pr_torchvision

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented May 7, 2024 •
edited
Loading

(created using eb --new-pr)

this makes sure libjpeg.so is linked into the image.so shared lib of torchvision for reading jpeg files, fixing the following error:

RuntimeError: decode_jpeg: torchvision not compiled with libjpeg support.

@smoors smoors mentioned this pull request May 7, 2024
Closed
boegel
boegel reviewed May 7, 2024
View reviewed changes
Comment thread easybuild/easyblocks/t/torchvision.py Outdated
@boegel boegel added this to the 4.x milestone May 7, 2024
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented May 7, 2024

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS torchvision-0.13.1-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node400.hydra.os - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7282 16-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/smoors/45852fbde0c654658aed60dcbcd6291d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 7, 2024

@smoors Can you clarify in the PR description why this is needed, or what type of build problem this fixes? (just so this PR is easy to find if people are looking for solutions to a build error)

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented May 8, 2024

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS torchvision-0.13.1-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node400.hydra.os - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7282 16-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/smoors/a020ee10bd578836ac5ab3a21a88f088 for a full test report.

@smoors smoors mentioned this pull request May 9, 2024
Merged
@smoors smoors modified the milestones: 4.x, release after 4.9.1 May 27, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 6, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS torchvision-0.16.0-foss-2023a-CUDA-12.1.1.eb
  • SUCCESS torchvision-0.13.1-foss-2022a-CUDA-11.7.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3303.joltik.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), 1 x NVIDIA Tesla V100-SXM2-32GB, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/65f6dd9658f322b6a0b329ad3d846c90 for a full test report.

boegel
boegel approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit a59df2e into easybuilders:develop Jun 7, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

The changes here introduced a problem for the sanity check of PyTorch-bundle, which is fixed in #3353

@boegel boegel mentioned this pull request Jun 8, 2024
Merged
@trz42 trz42 mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@smoors @boegel