Skip to content

avoid sanity check on the software itself for CargoPythonBundle easyblock#3341

Merged
Micket merged 2 commits intoeasybuilders:developfrom
smoors:20240524200516_new_pr_cargopythonbundle
Jun 5, 2024
Merged

avoid sanity check on the software itself for CargoPythonBundle easyblock#3341
Micket merged 2 commits intoeasybuilders:developfrom
smoors:20240524200516_new_pr_cargopythonbundle

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented May 24, 2024 •
edited
Loading

(created using eb --new-pr)

while trying to create an easyconfig for Safetensors (starts with upper case) with CargoPythonBundle using only a single extension safetensors (all lowercase), i got the following error:

== 2024-05-24 19:32:46,877 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:126 in init): Sanity check failed: command "python -c "import Safetensors"" failed; output:
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'Safetensors' (at easybuild/framework/easyblock.py:3663 in _sanity_check_step)

the reason (i think) is that it inherits from Cargo, which in turn inherits from ExtensionEasyBlock, so EB thinks the software itself is an extension.

the workaround proposed here is to set modulename to False, causing the sanity check to be skipped for the software itself.

@smoors smoors requested a review from Micket May 24, 2024 18:06
@smoors smoors added the bug fix label May 24, 2024
@smoors smoors added this to the release after 4.9.1 milestone May 24, 2024
Micket
Micket approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors mentioned this pull request May 25, 2024
Merged
@easybuilders easybuilders deleted a comment from boegelbot Jun 5, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2024

@boegelbot please test @ generoso
EB_ARGS="pydantic-2.5.3-GCCcore-12.3.0.eb tokenizers-0.15.2-GCCcore-12.3.0.eb maturin-1.3.2-GCCcore-11.3.0-Rust-1.65.0.eb"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jun 5, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3341 EB_ARGS="pydantic-2.5.3-GCCcore-12.3.0.eb tokenizers-0.15.2-GCCcore-12.3.0.eb maturin-1.3.2-GCCcore-11.3.0-Rust-1.65.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3341 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13649

Test results coming soon (I hope)...

Details

- notification for comment with ID 2150535149 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jun 5, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS pydantic-2.5.3-GCCcore-12.3.0.eb
  • SUCCESS tokenizers-0.15.2-GCCcore-12.3.0.eb
  • SUCCESS maturin-1.3.2-GCCcore-11.3.0-Rust-1.65.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/711a453cde4d788da6c8c24cdce47d77 for a full test report.

@Micket Micket merged commit 9e1cdf2 into easybuilders:develop Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @boegel @boegelbot @Micket