Skip to content

use run_shell_cmd (and use f-strings) in custom easyblock for GAMESS-US#3342

Merged
boegel merged 2 commits intoeasybuilders:5.0.xfrom
lexming:gamess-5.0
May 30, 2024
Merged

use run_shell_cmd (and use f-strings) in custom easyblock for GAMESS-US#3342
boegel merged 2 commits intoeasybuilders:5.0.xfrom
lexming:gamess-5.0

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented May 29, 2024

Changelog:

  • replace run_cmd with run_shell_cmd
  • use f-strings to format text

@lexming lexming added the EasyBuild-5.0 EasyBuild 5.0 label May 29, 2024
@lexming lexming added this to the 5.0 milestone May 29, 2024
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 29, 2024

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS GAMESS-US-20230930-R2-gompi-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/e87a8086eadac1973c093120a979132e for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Make GAMESS-US easyblock compliant with EasyBuild 5.0 use run_shell_cmd (and use f-strings) in custom easyblock for GAMESS-US May 30, 2024
@boegel boegel merged commit 3f8fccd into easybuilders:5.0.x May 30, 2024
@branfosj
Copy link
Copy Markdown
Member

Part of #3089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants