Merged
Conversation
Also did some indenting cleanup.
Member
There was a problem hiding this comment.
It's a good idea to give a warning when you change the default 😉
I wanted CP2K builds with libxc enabled. I've pushed changes to the easyconfg PR.
Member
Author
There was a problem hiding this comment.
Well, the existing easyconfigs broke because this was set to False by default.
In the future, we should determine whether these libint and libxc parameters are still useful. Why not build against libxc simply based on the fact whether it's there as a dep or not?
Now you need to both add it as a dep, and set libxc to True, which is just stupid.
Simply dropping these two shouldn't break anything, EB just ignores unknown entries in the easyconfig file...
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on top of @wpoely86's PR #323, fixes bug in definition of
test_core_cnt(which is not a real constant since it's not defined out of the class) and includes minor style fixestested with easybuilders/easybuild-easyconfigs#572 and easybuilders/easybuild-easyconfigs#601