Skip to content

fix import of parse in openssl_wrapper.py for Python 2.7#3364

Merged
boegel merged 4 commits intoeasybuilders:developfrom
branfosj:urlparse
Jun 18, 2024
Merged

fix import of parse in openssl_wrapper.py for Python 2.7#3364
boegel merged 4 commits intoeasybuilders:developfrom
branfosj:urlparse

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jun 17, 2024 •
edited
Loading

At least for a short time longer.

error

ERROR: Failed to process easyconfig /rds/projects/2017/branfosj-rse/easybuild/src/easybuild-easyconfigs/easybuild/easyconfigs/venv-py2/easybuild/easyconfigs/o/OpenSSL/OpenSSL-3.eb: Failed to obtain class for EB_OpenSSL_wrapper easyblock (not available?): No module named parse

Using --include-easyblocks-from-pr 3364 works.

@branfosj
support Python 2 in openssl_wrapper.py
e6ca241 
At least for a short time
@branfosj branfosj added this to the release after 4.9.2 milestone Jun 17, 2024
boegel
boegel requested changes Jun 18, 2024
View reviewed changes
Comment thread easybuild/easyblocks/o/openssl_wrapper.py Outdated
@branfosj @boegel
clearer comment
d19ca44 
Co-authored-by: Kenneth Hoste <[email protected]>
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 18, 2024

@boegelbot please test @ generoso
EB_ARGS="OpenSSL-1.1.eb OpenSSL-3.eb --installpath /tmp/$USER"

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 18, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3107.skitty.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/boegel/fad885bd822b174abd720993bfdc4f36 for a full test report.

@boegel boegel changed the title support Python 2 in openssl_wrapper.py fix import of parse in openssl_wrapper.py for Python 2.7 Jun 18, 2024
@boegelbot
Copy link
Copy Markdown

boegelbot commented Jun 18, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3364 EB_ARGS="OpenSSL-1.1.eb OpenSSL-3.eb --installpath /tmp/$USER" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3364 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13761

Test results coming soon (I hope)...

Details

- notification for comment with ID 2175586107 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jun 18, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb
  • SUCCESS OpenSSL-3.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3eca9bceb5de1f434c1086ea6885e5aa for a full test report.

@boegel boegel merged commit ad8dab3 into easybuilders:develop Jun 18, 2024
@branfosj branfosj deleted the urlparse branch June 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot