Use build dir for big files/folders while building TensorFlow#3371
Merged
branfosj merged 3 commits intoeasybuilders:developfrom Jul 3, 2024
Merged
Use build dir for big files/folders while building TensorFlow#3371branfosj merged 3 commits intoeasybuilders:developfrom
branfosj merged 3 commits intoeasybuilders:developfrom
Conversation
dc7cb56 to
9152a10
Compare
build_pip_package (executed after Bazel finishes) uses a temporary folder which gets large (2 GB for TF 2.9). It uses `$TMPDIR` (via mktemp) which we set to the temporary folder created by Easybuild in PythonPackage but that might have only enough space for logs etc. As this folder is part of the build put it inside the build directory.
9152a10 to
1a297ea
Compare
The build already creates files in $TMPDIR, so set that for the whole build and reset afterwards.
Same issue here, use a context manager to avoid duplicate code
Contributor
Author
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Member
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
branfosj
approved these changes
Jul 3, 2024
Member
|
Going in, thanks @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_pip_package (executed after Bazel finishes) uses a temporary folder which gets large (2 GB for TF 2.9).
It uses
$TMPDIR(via mktemp) which we set to the temporary folder created by Easybuild in PythonPackage but that might have only enough space for logs etc.As this folder is part of the build put it inside the build directory.