Skip to content

Explicitly call csh in custom easyblock for WPS#3384

Merged
boegel merged 2 commits intoeasybuilders:developfrom
thanghn90:patch-2
Jul 31, 2024
Merged

Explicitly call csh in custom easyblock for WPS#3384
boegel merged 2 commits intoeasybuilders:developfrom
thanghn90:patch-2

Conversation

@thanghn90
Copy link
Copy Markdown
Contributor

@thanghn90 thanghn90 commented Jul 6, 2024

For system that doesn't have csh installed, /bin/csh won't call into the csh provided by tcsh module (if loaded as a build dependency). Tested and confirmed working on a Rocky 9 Haswell server.

thanghn90 added 2 commits July 5, 2024 21:29
@thanghn90
Explicitly calling csh in wps.py easyblock
d4076b0 
For system that doesn't have csh installed, /bin/csh won't call into the csh provided by tcsh module (if loaded as a build dependency). Tested and confirmed working on a Rocky 9 Haswell server.
@thanghn90
Calling csh command for link_grib.csh
1e24ea4 
Forgot this as well to prevent failure in testing step for system that doesn't have csh installed.
@thanghn90 thanghn90 mentioned this pull request Jul 6, 2024
Open
@boegel boegel changed the title Explicitly calling csh in wps.py easyblock Explicitly calling csh in custom easyblock for WPS Jul 31, 2024
boegel
boegel approved these changes Jul 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Jul 31, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 31, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2024

@boegelbot please test @ generoso
EB_ARGS="WPS-3.9.1-foss-2020b-dmpar.eb WPS-4.3.1-foss-2021a-dmpar.eb WPS-4.4-foss-2022a-dmpar.eb"

@boegel boegel changed the title Explicitly calling csh in custom easyblock for WPS Explicitly call csh in custom easyblock for WPS Jul 31, 2024
@boegelbot
Copy link
Copy Markdown

boegelbot commented Jul 31, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3384 EB_ARGS="WPS-3.9.1-foss-2020b-dmpar.eb WPS-4.3.1-foss-2021a-dmpar.eb WPS-4.4-foss-2022a-dmpar.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3384 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13980

Test results coming soon (I hope)...

Details

- notification for comment with ID 2260599653 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jul 31, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS WPS-3.9.1-foss-2020b-dmpar.eb
  • SUCCESS WPS-4.3.1-foss-2021a-dmpar.eb
  • SUCCESS WPS-4.4-foss-2022a-dmpar.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/37502d1bd1b135f50f6c016f2f9541b2 for a full test report.

@boegel boegel merged commit 871d9be into easybuilders:develop Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@thanghn90 @boegel @boegelbot