Skip to content

fix extra $PATH entry for OCaml to use opam/default rather than opam/system#3390

Merged
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:develop
Aug 14, 2024
Merged

fix extra $PATH entry for OCaml to use opam/default rather than opam/system#3390
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:develop

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jul 10, 2024

For OCaml/5.1.1-GCC-13.2.0 on generoso and for OCaml/4.14.0-GCC-11.3.0 on my system there is no opam/system but there is opam/default and this contains ocamlfind

@branfosj branfosj mentioned this pull request Jul 10, 2024
Closed
1 task
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jul 10, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS OCaml-4.14.0-GCC-11.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/9feae9561a08c50ad07a052e3d42079b for a full test report.

bartoldeman
bartoldeman previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@branfosj branfosj added this to the release after 4.9.2 milestone Jul 15, 2024
@boegel boegel changed the title change extra path for OCaml change extra path for OCaml to use default rather than system Jul 31, 2024
@boegel boegel changed the title change extra path for OCaml to use default rather than system change extra $PATH entry for OCaml to use opam/default rather than opam/system Jul 31, 2024
boegel
boegel requested changes Jul 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj Let's add "ocamlfind list" as sanity check command to catch this bug?

Maybe that should only be done conditionally though, when ocamlfind is being installed as extension?

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jul 31, 2024

@branfosj Let's add "ocamlfind list" as sanity check command to catch this bug?

Maybe that should only be done conditionally though, when ocamlfind is being installed as extension?

Done in bc7fa88.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 13, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="OCaml-4.14.0-GCC-11.3.0.eb OCaml-5.1.1-GCC-13.2.0.eb"

boegel
boegel approved these changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown

boegelbot commented Aug 13, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3390 EB_ARGS="OCaml-4.14.0-GCC-11.3.0.eb OCaml-5.1.1-GCC-13.2.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3390 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4672

Test results coming soon (I hope)...

Details

- notification for comment with ID 2287170284 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Aug 13, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OCaml-4.14.0-GCC-11.3.0.eb
  • SUCCESS OCaml-5.1.1-GCC-13.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/39d7551c0796de6ab8a6b2c6f0bdf8c7 for a full test report.

@boegel boegel merged commit 9490b45 into easybuilders:develop Aug 14, 2024
@boegel boegel changed the title change extra $PATH entry for OCaml to use opam/default rather than opam/system fix extra $PATH entry for OCaml to use opam/default rather than opam/system Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@bartoldeman bartoldeman bartoldeman left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegel @boegelbot @bartoldeman