Skip to content

enhance binutils easyblock to explicitely pass msgpack configure option#3438

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20240910101650_new_pr_binutils
Sep 11, 2024
Merged

enhance binutils easyblock to explicitely pass msgpack configure option#3438
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20240910101650_new_pr_binutils

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 10, 2024 •
edited
Loading

(created using eb --new-pr)

This avoids an error when using readelf when msgpack was installed on the system during configure but is not available at runtime on the node where it is used:

readelf: error while loading shared libraries: libmsgpackc.so.2: cannot open shared object file: No such file or directory

We have "msgpack-c" EasyConfigs which could be used, so add a check for that but error out if used prior to where the support in binutils was introduced: https://github.com/bminor/binutils-gdb/commit/2952f10cd79af4645222f124f28c7928287d8113

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 10, 2024

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb
  • SUCCESS binutils-2.42.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
login1 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/f8839435528434c6394d0b2cbaf1a078 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 10, 2024

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.39.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb
  • SUCCESS binutils-2.40.eb
  • SUCCESS binutils-2.40-GCCcore-12.3.0.eb
  • SUCCESS binutils-2.40-GCCcore-13.1.0.eb
  • SUCCESS binutils-2.40-GCCcore-13.2.0.eb
  • SUCCESS binutils-2.42.eb
  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb

Build succeeded for 8 out of 8 (8 easyconfigs in total)
login2.romeo.hpc.tu-dresden.de - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/a7ad7c48761c26622398e8e602424f72 for a full test report.

@boegel boegel changed the title explicitely pass msgpack configure option to binutils enhance binutils easyblock to explicitely pass msgpack configure option Sep 11, 2024
@boegel boegel added this to the release after 4.9.2 milestone Sep 11, 2024
boegel
boegel approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2024

@boegelbot please test @ generoso
EB_ARGS="binutils-2.37.eb binutils-2.38-GCCcore-11.3.0.eb binutils-2.39.eb binutils-2.39-GCCcore-12.2.0.eb binutils-2.42-GCCcore-13.3.0.eb binutils-2.42.eb --installpath /tmp/$USER/pr3438"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 11, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3438 EB_ARGS="binutils-2.37.eb binutils-2.38-GCCcore-11.3.0.eb binutils-2.39.eb binutils-2.39-GCCcore-12.2.0.eb binutils-2.42-GCCcore-13.3.0.eb binutils-2.42.eb --installpath /tmp/$USER/pr3438" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3438 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14236

Test results coming soon (I hope)...

Details

- notification for comment with ID 2342810032 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 11, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.37.eb
  • SUCCESS binutils-2.38-GCCcore-11.3.0.eb
  • SUCCESS binutils-2.39.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb
  • SUCCESS binutils-2.42.eb
  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/658191c43e9f2dd256e57a24accc89fd for a full test report.

@boegel boegel merged commit d3ecacd into easybuilders:develop Sep 11, 2024
@Flamefire Flamefire deleted the 20240910101650_new_pr_binutils branch September 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @boegelbot