Skip to content

enhance custom easyblock for NCCL: add licence to NCCL installation#3451

Merged
boegel merged 1 commit intoeasybuilders:developfrom
laraPPr:NCCL
Sep 19, 2024
Merged

enhance custom easyblock for NCCL: add licence to NCCL installation#3451
boegel merged 1 commit intoeasybuilders:developfrom
laraPPr:NCCL

Conversation

@laraPPr
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr commented Sep 19, 2024

No description provided.

@laraPPr laraPPr mentioned this pull request Sep 19, 2024
Merged
3 tasks
boegel
boegel approved these changes Sep 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the release after 4.9.3 milestone Sep 19, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 19, 2024

@boegelbot please test @ generoso
EB_ARGS="NCCL-2.10.3-GCCcore-10.3.0-CUDA-11.3.1.eb NCCL-2.18.3-GCCcore-12.3.0-CUDA-12.1.1.eb"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 19, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3451 EB_ARGS="NCCL-2.10.3-GCCcore-10.3.0-CUDA-11.3.1.eb NCCL-2.18.3-GCCcore-12.3.0-CUDA-12.1.1.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3451 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14299

Test results coming soon (I hope)...

Details

- notification for comment with ID 2361286509 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel modified the milestones: release after 4.9.3, 4.9.4 Sep 19, 2024
@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 19, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS NCCL-2.10.3-GCCcore-10.3.0-CUDA-11.3.1.eb
  • SUCCESS NCCL-2.18.3-GCCcore-12.3.0-CUDA-12.1.1.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/63c77b26055fd82cf2b9583d8a5a5e59 for a full test report.

@boegel boegel merged commit 9193996 into easybuilders:develop Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.4

Development

Successfully merging this pull request may close these issues.

3 participants

@laraPPr @boegel @boegelbot