add support for recent netCDF versions, add easyblock for netcdf4-python#347
add support for recent netCDF versions, add easyblock for netcdf4-python#347boegel merged 2 commits intoeasybuilders:developfrom
Conversation
There was a problem hiding this comment.
OK, I see the super replacement below with a conditional and understand the need for different build procedures, per case of version. But, here's the question:
- what makes inheriting
CMakeMakepreferred overConfigureMake? what's the point of this?
There was a problem hiding this comment.
CMakeMake inherits from ConfigureMake
There was a problem hiding this comment.
so, I guess objective is to reduce total lines of code...
There was a problem hiding this comment.
Yes, they are the same except for the configure_step, so you can easily switch between them.
There was a problem hiding this comment.
In the end, it doesn't matter that much, it's just cleaner. It looks weird, but that's only because CMakeMake indeed derives from ConfigureMake. If not, you would have multiple inheritance (e.g. class A(X, Y)).
|
going in now easybuilders/easybuild-easyconfigs#660 is fully ready Thanks for the review @fgeorgatos! |
add support for recent netCDF versions, add easyblock for netcdf4-python
No description provided.