Skip to content

enhance cuDNN easyblock to verify that EULA is accepted before installing it#3473

Merged
boegel merged 1 commit intodevelopfrom
ocaisa-patch-1
Oct 9, 2024
Merged

enhance cuDNN easyblock to verify that EULA is accepted before installing it#3473
boegel merged 1 commit intodevelopfrom
ocaisa-patch-1

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Oct 8, 2024

No description provided.

@boegel boegel changed the title cuDNN requires EULA enhance cuDNN easyblock to verify that EULA is accepted before installing it Oct 9, 2024
@boegel boegel added this to the release after 4.9.4 milestone Oct 9, 2024
@easybuilders easybuilders deleted a comment from boegelbot Oct 9, 2024
@easybuilders easybuilders deleted a comment from boegelbot Oct 9, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 9, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--accept-eula-for=CUDA,cuDNN --installpath /tmp/$USER/pr3473 cuDNN-8.9.7.29-CUDA-12.3.0.eb"

@boegelbot
Copy link
Copy Markdown

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3473 EB_ARGS="--accept-eula-for=CUDA,cuDNN --installpath /tmp/$USER/pr3473 cuDNN-8.9.7.29-CUDA-12.3.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3473 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5034

Test results coming soon (I hope)...

Details

- notification for comment with ID 2401594290 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS cuDNN-8.9.7.29-CUDA-12.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d748407286caf559292ff49e472ddb0b for a full test report.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Oct 9, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--accept-eula-for=CUDA --installpath /tmp/$USER/pr3473_2 cuDNN-8.9.7.29-CUDA-12.3.0.eb"

@boegelbot
Copy link
Copy Markdown

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3473 EB_ARGS="--accept-eula-for=CUDA --installpath /tmp/$USER/pr3473_2 cuDNN-8.9.7.29-CUDA-12.3.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3473 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5035

Test results coming soon (I hope)...

Details

- notification for comment with ID 2401605815 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/0a706515eebb5095c86e7f9c18a7c181 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Oct 9, 2024

@boegel The last test was an expected failure that shows that this works: the cuDNN EULA had not been accepted.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 11afb88 into develop Oct 9, 2024
@boegel boegel deleted the ocaisa-patch-1 branch October 9, 2024 16:36
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants