Skip to content

also add path to libtorch.so & co to $LIBRARY_PATH in generated module file for PyTorch#3488

Merged
laraPPr merged 1 commit intoeasybuilders:developfrom
boegel:20241015214234_new_pr_pytorch
Oct 16, 2024
Merged

also add path to libtorch.so & co to $LIBRARY_PATH in generated module file for PyTorch#3488
laraPPr merged 1 commit intoeasybuilders:developfrom
boegel:20241015214234_new_pr_pytorch

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 15, 2024 •
edited
Loading

(created using eb --new-pr)

fix for failing RPATH sanity check for dorado when using RPATH linking:

Sanity check failed:
Library libtorch.so not found for /software/dorado/0.7.3-foss-2023a-CUDA-12.1.1/bin/dorado
Library libtorch_cpu.so not found for /software/dorado/0.7.3-foss-2023a-CUDA-12.1.1/bin/dorado
...

@boegel boegel mentioned this pull request Oct 15, 2024
Closed
@boegel boegel added bug fix EESSI Related to EESSI project labels Oct 15, 2024
@boegel boegel added this to the release after 4.9.4 milestone Oct 15, 2024
@boegel boegel changed the title also add path to libtorch.so & co to $LIBRARY_PATH in generated module file for PyTorch also add path to libtorch.so & co to $LIBRARY_PATH in generated module file for PyTorch Oct 15, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 15, 2024

Works as intended, diff after re-generating module file with --module-only:

$ diff -u /apps/gent/RHEL9/cascadelake-volta-ib/modules/all/PyTorch/2.1.2-foss-2023a-CUDA-12.1.1.lua.bk /apps/gent/RHEL9/cascadelake-volta-ib/modules/all/PyTorch/2.1.2-foss-2023a-CUDA-12.1.1.lua
--- /apps/gent/RHEL9/cascadelake-volta-ib/modules/all/PyTorch/2.1.2-foss-2023a-CUDA-12.1.1.lua.bk       2024-10-12 00:17:25.068272275 +0200
+++ /apps/gent/RHEL9/cascadelake-volta-ib/modules/all/PyTorch/2.1.2-foss-2023a-CUDA-12.1.1.lua  2024-10-15 21:45:59.651791287 +0200
@@ -110,6 +110,7 @@

 prepend_path("CMAKE_PREFIX_PATH", pathJoin(root, "lib/python3.11/site-packages/torch"))
 prepend_path("LD_LIBRARY_PATH", pathJoin(root, "lib/python3.11/site-packages/torch/lib"))
+prepend_path("LIBRARY_PATH", pathJoin(root, "lib/python3.11/site-packages/torch/lib"))
 prepend_path("PATH", pathJoin(root, "bin"))
 setenv("EBROOTPYTORCH", root)
 setenv("EBVERSIONPYTORCH", "2.1.2")

@boegel boegel requested a review from laraPPr October 15, 2024 19:50
laraPPr
laraPPr approved these changes Oct 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr laraPPr merged commit 5718bdf into easybuilders:develop Oct 16, 2024
@boegel boegel deleted the 20241015214234_new_pr_pytorch branch October 16, 2024 08:32
@boegel boegel mentioned this pull request Oct 16, 2024
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 16, 2024

All PyTorch module files on both generoso and jsc-zen3 have been re-generated via --module-only to ensure they also update $LIBRARY_PATH

@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laraPPr laraPPr laraPPr approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @laraPPr