Skip to content

remove use of deprecated parse_log_for_error in RPackage easyblock#3515

Merged
lexming merged 4 commits intoeasybuilders:5.0.xfrom
branfosj:20241123163528_new_pr_rpackage
Dec 21, 2024
Merged

remove use of deprecated parse_log_for_error in RPackage easyblock#3515
lexming merged 4 commits intoeasybuilders:5.0.xfrom
branfosj:20241123163528_new_pr_rpackage

Conversation

@branfosj
Copy link
Copy Markdown
Member

(created using eb --new-pr)

boegel
boegel previously requested changes Dec 3, 2024
Comment thread easybuild/easyblocks/generic/rpackage.py Outdated
@boegel boegel changed the title remove use of deprecated parse_log_for_error in rpackage remove use of deprecated parse_log_for_error in RPackage easyblock` Dec 3, 2024
@boegel boegel changed the title remove use of deprecated parse_log_for_error in RPackage easyblock` remove use of deprecated parse_log_for_error in RPackage easyblock Dec 3, 2024
@branfosj
Copy link
Copy Markdown
Member Author

There are test reports using this in easybuilders/easybuild-easyconfigs#21908

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 21, 2024

Merging, thanks @branfosj

@lexming lexming dismissed boegel’s stale review December 21, 2024 11:47

Review addressed by author

@lexming lexming merged commit 6ea38b6 into easybuilders:5.0.x Dec 21, 2024
@branfosj branfosj deleted the 20241123163528_new_pr_rpackage branch December 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants