Skip to content

remove Python 2 fallback in openssl_wrapper#3544

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:py2
Jan 1, 2025
Merged

remove Python 2 fallback in openssl_wrapper#3544
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:py2

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Dec 31, 2024

No description provided.

@branfosj branfosj added this to the 5.0 milestone Dec 31, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 31, 2024 •
edited
Loading

@boegelbot please test @ jsc-zen3
EB_ARGS="OpenSSL-1.1.eb OpenSSL-3.eb"
EB_BRANCH=5.0.x

boegel
boegel approved these changes Dec 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown

boegelbot commented Dec 31, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3544 EB_ARGS="OpenSSL-1.1.eb OpenSSL-3.eb" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3544 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5484

Test results coming soon (I hope)...

Details

- notification for comment with ID 2566550901 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Dec 31, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb
  • SUCCESS OpenSSL-3.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/efe7eeec3d979f24691d356350390788 for a full test report.

@boegel boegel merged commit 29b260d into easybuilders:5.0.x Jan 1, 2025
@branfosj branfosj deleted the py2 branch January 1, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

code cleanup EasyBuild-5.0 EasyBuild 5.0

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot