Skip to content

adopt module_load_environment in generic Rpm easyblock #3561

Merged
boegel merged 9 commits intoeasybuilders:5.0.xfrom
lexming:modload-rpm
Jan 20, 2025
Merged

adopt module_load_environment in generic Rpm easyblock #3561
boegel merged 9 commits intoeasybuilders:5.0.xfrom
lexming:modload-rpm

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jan 17, 2025

Update of RPM easyblock for #3527

@boegel boegel changed the title adopt module_load_environment: RPM adopt module_load_environment: RPM Jan 20, 2025
boegel
boegel previously approved these changes Jan 20, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title adopt module_load_environment: RPM adopt module_load_environment in generic Rpm easyblock Jan 20, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 20, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS bcl-convert-4.0.3-2el7.x86_64.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3502.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/2637f94eb49f24388bec43c6834c821c for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes the sync with 5.0.x that's also done in #3564, which I did to make CI go green, but I won't bother to try and clean that up, changes to Rpm easyblock to adopt module_load_environment make sense and have been tested, and that actually unblocks #3564 which fails in CI for Rpm easyblock, so merging this instead...

@boegel boegel merged commit e0de69f into easybuilders:5.0.x Jan 20, 2025
@lexming lexming deleted the modload-rpm branch January 20, 2025 17:52
@boegel boegel added the change label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants