add support for Sapphire Rapids in LAMMPS easyblock#3569
Merged
ocaisa merged 1 commit intoeasybuilders:developfrom Jan 29, 2025
Merged
add support for Sapphire Rapids in LAMMPS easyblock#3569ocaisa merged 1 commit intoeasybuilders:developfrom
ocaisa merged 1 commit intoeasybuilders:developfrom
Conversation
ocaisa
approved these changes
Jan 28, 2025
Member
ocaisa
left a comment
There was a problem hiding this comment.
Need an actual build on the arch to make sure this works so relying on the EESSI build as a test report
Member
|
Confirmation in EESSI/software-layer#901 (comment) that this works, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the same approach as for Icelake, support for Sapphire Rapids was also added in version 2Aug2023, see https://github.com/lammps/lammps/blob/stable_2Aug2023/lib/kokkos/cmake/kokkos_arch.cmake#L62.
Do note that the 2Aug2023 has a dependency on a too old archspec version which detects Sapphire Rapids as Icelake, so we may want to have another fix for that (e.g. modify the archspec version in the easyconfig?).