Skip to content

enhance FlexiBLAS easyblock to add support for AOCL-BLAS backend#3589

Merged
boegel merged 4 commits intoeasybuilders:5.0.xfrom
lcniel:20250211160422_new_pr_flexiblas
Feb 16, 2025
Merged

enhance FlexiBLAS easyblock to add support for AOCL-BLAS backend#3589
boegel merged 4 commits intoeasybuilders:5.0.xfrom
lcniel:20250211160422_new_pr_flexiblas

Conversation

@lcniel
Copy link
Copy Markdown
Contributor

@lcniel lcniel commented Feb 11, 2025

(created using eb --new-pr)

Micket
Micket previously requested changes Feb 12, 2025
Comment thread easybuild/easyblocks/f/flexiblas.py Outdated
@Micket Micket added feature EasyBuild-5.0 EasyBuild 5.0 labels Feb 12, 2025
Comment thread easybuild/easyblocks/f/flexiblas.py Outdated
@boegel boegel added this to the 5.0 milestone Feb 12, 2025
@boegel boegel changed the title Support for AOCL-BLAS backend enhance FlexiBLAS easyblock to add support for AOCL-BLAS backend Feb 12, 2025
@lcniel lcniel requested review from Micket and appolloford February 12, 2025 16:35
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2025

@bartoldeman Can you take a look at this?

Comment thread easybuild/easyblocks/f/flexiblas.py Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 16, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS FlexiBLAS-3.4.4-GCC-13.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3541.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/bb476e444e6d6155becc403b7f538754 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel dismissed Micket’s stale review February 16, 2025 13:31

requested change made

@boegel boegel merged commit 49c5c81 into easybuilders:5.0.x Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants