Skip to content

adopt module_load_environment in XALT easyblock#3593

Merged
lexming merged 1 commit intoeasybuilders:5.0.xfrom
boegel:20250213085817_new_pr_xalt
Feb 13, 2025
Merged

adopt module_load_environment in XALT easyblock#3593
lexming merged 1 commit intoeasybuilders:5.0.xfrom
boegel:20250213085817_new_pr_xalt

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 13, 2025

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 13, 2025

Tested with updated XALT easyconfig from easybuilders/easybuild-easyconfigs#22299 on top of:

I had to use eb --disable-rpath for this, because XALT copies over OS libraries like libpthread.so.1 (which is provided by glibc) into its installation. Fixing that would require using patchelf in the easyconfig.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 13, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS XALT-3.1.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3561.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/a86e6ba4433e41483c5a042bbb1b37d7 for a full test report.

@boegel boegel changed the title adopt module_load_environment in XALT easyblock adopt module_load_environment in XALT easyblock Feb 13, 2025
@lexming lexming merged commit d0089d0 into easybuilders:5.0.x Feb 13, 2025
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 13, 2025

@boegel would it make sense to disable rpath altogether in the easyblock of XALT to avoid those issues? Something like we do on systemcompiler:

self.toolchain.options['rpath'] = False

@boegel boegel deleted the 20250213085817_new_pr_xalt branch February 16, 2025 12:40
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 16, 2025

@boegel would it make sense to disable rpath altogether in the easyblock of XALT to avoid those issues? Something like we do on systemcompiler:

self.toolchain.options['rpath'] = False

I'm more in favor of trying to use patchelf to patch the (system) libraries copied by XALT...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants