Skip to content

add support to OpenFOAM easyblock for custom sanity_check_motorbike easyconfig parameter to opt out of running motorBike tutorial example during sanity check#3595

Merged
boegel merged 3 commits intoeasybuilders:developfrom
pavelToman:patch-1
Feb 14, 2025
Merged

add support to OpenFOAM easyblock for custom sanity_check_motorbike easyconfig parameter to opt out of running motorBike tutorial example during sanity check#3595
boegel merged 3 commits intoeasybuilders:developfrom
pavelToman:patch-1

Conversation

@pavelToman
Copy link
Copy Markdown
Contributor

@pavelToman pavelToman commented Feb 13, 2025 •
edited
Loading

This provide more customizable sanity check for OpenFOAM easyconfig - standard sanity check fails on motorBike tutorial check without ParaView installed.

resolves vscentrum/vsc-software-stack#481
needed by:

This was referenced Feb 13, 2025
Closed
Merged
@boegel boegel changed the title Update openfoam.py - add sanity_check_motorbike variable for versions without ParaView add support to OpenFOAM easyblock for custom sanity_check_motorbike easyconfig parameter to opt out of running motorBike tutorial example during sanity check Feb 13, 2025
boegel
boegel approved these changes Feb 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 13, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-9-foss-2021a.eb
  • SUCCESS OpenFOAM-12-foss-2023a.eb
  • SUCCESS OpenFOAM-v2312-foss-2023a.eb
  • SUCCESS OpenFOAM-Extend-4.1-20210705-foss-2023a-Python-2.7.18.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node4004.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), 1 x NVIDIA NVIDIA A2, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/42e0916da8ed8d467366b629db30a035 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 13, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="OpenFOAM-8-foss-2023a.eb OpenFOAM-12-foss-2023a.eb OpenFOAM-v2406-foss-2023a.eb --sanity-check-only"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Feb 13, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3595 EB_ARGS="OpenFOAM-8-foss-2023a.eb OpenFOAM-12-foss-2023a.eb OpenFOAM-v2406-foss-2023a.eb --sanity-check-only" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3595 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5718

Test results coming soon (I hope)...

Details

- notification for comment with ID 2657323606 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Feb 13, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-8-foss-2023a.eb
  • SUCCESS OpenFOAM-12-foss-2023a.eb
  • SUCCESS OpenFOAM-v2406-foss-2023a.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/d8215c739b801cbd25eafc765d3af885 for a full test report.

@boegel boegel added this to the release after 4.9.4 milestone Feb 14, 2025
@boegel boegel merged commit 8b51ccf into easybuilders:develop Feb 14, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

OpenFOAM-6 on RHEL9

3 participants

@pavelToman @boegel @boegelbot