Skip to content

Fix bug in FlexiBLAS easyblock to allow AOCL-BLAS to be default#3605

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
lcniel:patch-1
Feb 26, 2025
Merged

Fix bug in FlexiBLAS easyblock to allow AOCL-BLAS to be default#3605
boegel merged 1 commit intoeasybuilders:5.0.xfrom
lcniel:patch-1

Conversation

@lcniel
Copy link
Copy Markdown
Contributor

@lcniel lcniel commented Feb 17, 2025 •
edited
Loading

In the current version, if one sets AOCL-BLAS as the default, it will be (silently) ignored and FlexiBLAS will use NETLIB instead, since the eventual name of the AOCL-BLAS backend will be the CMake name, AOCL_MT. This PR fixes this by substituting the name in configopts['FLEXIBLAS_DEFAULT'], just like how it's handled in the backends variable.

@boegel boegel added bug fix EasyBuild-5.0 EasyBuild 5.0 labels Feb 26, 2025
@boegel boegel added this to the 5.0 milestone Feb 26, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 26, 2025

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x
EB_ARGS="FlexiBLAS-3.4.4-GCC-13.3.0.eb --installpath /tmp/$USER/pr3605"

@boegel boegel changed the title Fix bug in flexiblas EasyBlock to allow AOCL-BLAS to be default Fix bug in FlexiBLAS easyblock to allow AOCL-BLAS to be default Feb 26, 2025
@boegelbot
Copy link
Copy Markdown

boegelbot commented Feb 26, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3605 EB_ARGS="FlexiBLAS-3.4.4-GCC-13.3.0.eb --installpath /tmp/$USER/pr3605" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3605 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5788

Test results coming soon (I hope)...

Details

- notification for comment with ID 2684215923 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Feb 26, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS FlexiBLAS-3.4.4-GCC-13.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/2364f4c511acc964d17feec48e7463c1 for a full test report.

@boegel boegel merged commit 0b7b6b5 into easybuilders:5.0.x Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix EasyBuild-5.0 EasyBuild 5.0

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lcniel @boegel @boegelbot