fix Molpro easyblock in module-only mode + adopt module_load_environment#3615
Merged
boegel merged 2 commits intoeasybuilders:5.0.xfrom Feb 17, 2025
Merged
fix Molpro easyblock in module-only mode + adopt module_load_environment#3615boegel merged 2 commits intoeasybuilders:5.0.xfrom
module_load_environment#3615boegel merged 2 commits intoeasybuilders:5.0.xfrom
Conversation
… case configure step was skipped
82 tasks
Contributor
Author
|
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
module_load_environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3614 and updates for #3527
Molpro easyblock heavily relies on
self.full_prefixwhich is defined from aCONFIGfile that only exists in the build directory.make_module_req_guesswithmodule_load_environmentand define glob patterns forPATHto possible locations of executables. This avoids needingself.full_prefix.self.full_prefixis empty. In such a case, try to also determine installation prefix based on a simple glob pattern.