Skip to content

revamp NEURON easyblock, incl. adopt module_load_environment#3618

Merged
boegel merged 7 commits intoeasybuilders:5.0.xfrom
lexming:modload-neuron
Feb 18, 2025
Merged

revamp NEURON easyblock, incl. adopt module_load_environment#3618
boegel merged 7 commits intoeasybuilders:5.0.xfrom
lexming:modload-neuron

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 18, 2025 •
edited
Loading

  • remove code for old versions of NEURON already archived
  • replace make_module_req_guess with module_load_environment
  • add support for NEURON version 8
  • make NEURON easyblock compatible with --module-only:
    • move MPI test to test step because those needs sources in the build directory
    • declare commands in sanity check with neurondemo and python imports as custom commands instead of using run_shell_cmd

@lexming lexming added the EasyBuild-5.0 EasyBuild 5.0 label Feb 18, 2025
@lexming lexming added this to the 5.0 milestone Feb 18, 2025
This was referenced Feb 18, 2025
Closed
Merged
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 18, 2025 •
edited
Loading

Regular tests

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS NEURON-7.8.2-foss-2021b.eb
  • SUCCESS NEURON-8.2.6-foss-2023a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
login2.cerberus.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/1187ac66ab60c8830c9f9e97243364d4 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 18, 2025 •
edited
Loading

Tests with --module-only

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS NEURON-7.8.2-foss-2021b.eb
  • SUCCESS NEURON-8.2.6-foss-2023a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
login2.cerberus.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/393c3c91404b1f16c187996c19291872 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS NEURON-7.8.2-foss-2021b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3514.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/be7ff6be1e9d1e33517b7c99abb90221 for a full test report.

@boegel boegel changed the title revamp NEURON easyblock revamp NEURON easyblock, incl. adopt module_load_environment Feb 18, 2025
boegel
boegel approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 1c1cb7e into easybuilders:5.0.x Feb 18, 2025
@lexming lexming deleted the modload-neuron branch February 18, 2025 20:04
@lexming lexming mentioned this pull request Feb 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change code cleanup EasyBuild-5.0 EasyBuild 5.0 update

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lexming @boegel