adopt module_load_environment in custom easyblock for TINKER#3625
adopt module_load_environment in custom easyblock for TINKER#3625lexming merged 2 commits intoeasybuilders:5.0.xfrom
module_load_environment in custom easyblock for TINKER#3625Conversation
10e2e63 to
f3a2042
Compare
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
lexming
left a comment
There was a problem hiding this comment.
My installation of TINKER does not have any tinker subdir:
TINKER/8.11.3-foss-2023a/
├── bin
├── easybuild
├── lib -> lib64
├── lib64
├── params
├── perl
└── python
This might be a relic of the past? I see that it was the case in TINKER/8.6.1-foss-2018b.
So replacing the default $PATH and $LD_LIBRARY_PATH will break things with current version. If you want to keep backward compatibility we can PATH.append() those paths.
fixed in 0a1b016 |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
(created using
eb --new-pr)