Skip to content

set minimum supported version of PETSc to v3.9 and adopt module_load_environment#3627

Merged
boegel merged 7 commits intoeasybuilders:5.0.xfrom
lexming:modload-petsc
Feb 20, 2025
Merged

set minimum supported version of PETSc to v3.9 and adopt module_load_environment#3627
boegel merged 7 commits intoeasybuilders:5.0.xfrom
lexming:modload-petsc

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 19, 2025 •
edited
Loading

This one became bigger than expected:

  • remove code for versions of PETSc prior to v3.9 (2018a)
  • set version 3.9 as minimum supported version (error on lower versions)
  • replace make_module_req_guess with module_load_environment on init (for #3527)
  • replace attributes prefix_bin, prefix_lib and prefix_inc with properties bin_dir, lib_dir and inc_dirs to more clearly define the location of files depending on the type of install (regular installs and sourceinstall installs have quite different topologies)
  • fix installations with sourceinstall enabled in module-only mode by adding an extra check on PETSC_ARCH in the sanity check step

@lexming lexming added the EasyBuild-5.0 EasyBuild 5.0 label Feb 19, 2025
@lexming lexming added this to the 5.0 milestone Feb 19, 2025
@lexming lexming mentioned this pull request Feb 19, 2025
Closed
82 tasks
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 20, 2025 •
edited
Loading

Tests in module-only

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.17.4-foss-2022a.eb >> default install
  • SUCCESS PETSc-3.20.3-foss-2023a.eb >> sourceinstall enabled

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node314.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.9.20
See https://gist.github.com/lexming/742c4976f9e5bbddd96824c9585f35d6 for a full test report.

@lexming lexming mentioned this pull request Feb 20, 2025
Merged
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 20, 2025 •
edited
Loading

Tests for full installs

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.17.4-foss-2022a.eb >> default install
  • SUCCESS PETSc-3.20.3-foss-2023a.eb >> sourceinstall enabled

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node311.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.9.20
See https://gist.github.com/lexming/0eedfd36b56bc97a1d00bb707f861945 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 20, 2025

I took an initial smaller step in #3632, which should be closed I guess, I'll take a look at this one instead...

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 20, 2025 •
edited
Loading

@boegel we can merge yours and then I rebase this one on top. Then it will be easier to review this one.

boegel
boegel approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 20, 2025

@boegel we can merge yours and then I rebase this one on top. Then it will be easier to review this one.

No, it's fine, this is not that difficult to follow if you ignore the whitespace differences

@boegel boegel mentioned this pull request Feb 20, 2025
Closed
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 20, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.20.3-foss-2023a.eb
  • SUCCESS PETSc-3.15.1-foss-2021a.eb
  • SUCCESS PETSc-3.18.4-intel-2021b.eb
  • SUCCESS PETSc-3.17.4-foss-2022a.eb
  • SUCCESS PETSc-3.14.4-foss-2020b.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3515.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/595909eefff508c69667a89983e8d599 for a full test report.

@boegel boegel merged commit 3503c25 into easybuilders:5.0.x Feb 20, 2025
@lexming lexming deleted the modload-petsc branch February 20, 2025 21:26
@lexming lexming mentioned this pull request Feb 22, 2025
Merged
@lexming lexming mentioned this pull request Jul 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change code cleanup EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lexming @boegel