Skip to content

added glob support in generic makecp block#367

Merged
boegel merged 2 commits intoeasybuilders:developfrom
pescobar:makecp-glob
Mar 27, 2014
Merged

added glob support in generic makecp block#367
boegel merged 2 commits intoeasybuilders:developfrom
pescobar:makecp-glob

Conversation

@pescobar
Copy link
Copy Markdown
Member

No description provided.

pescobar referenced this pull request in pescobar/easybuild-easyconfigs Feb 26, 2014
Comment thread easybuild/easyblocks/generic/makecp.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bad example, since you could just copy the scripts directory. make the example "scripts/*.sh"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, @boegel explained the diffeence, this is to copy all files in scripts to bin, not make a subdir in bin. (however, you could add scripts to PATH ;)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stdweird
Copy link
Copy Markdown
Contributor

@pescobar this also needs a unittest

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 28, 2014

@stdweird: there's no easy way to write a unit test for this, since it's in an easyblock... This will be tested by an easyconfig that relies on this functionality.
@pescobar: Can you point to (a PR with) an easyconfig that relies on this?

@pescobar
Copy link
Copy Markdown
Member Author

@boegel @stdweird
I have tried this easyblock with this easyconfig and works in my side
https://gist.github.com/pescobar/9272904

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 28, 2014

@pescobar: any open PR for this easyconfig yet? Please refer to it if it's opened.

@pescobar
Copy link
Copy Markdown
Member Author

@boegel I did this PR using it pescobar/easybuild-easyconfigs@572be72

But after this, following the suggestion of a bioinformatics here, I changed the config. Here you have my full comment on this. easybuilders/easybuild-easyconfigs#724 (comment)

So right now no PR using this feature, I just tested it with this ebfile https://gist.github.com/pescobar/9272904

Up to you if you want to include this in the master branch. I can customize my local makecp block if I need it

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 26, 2014

Jenkins: test this please

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 26, 2014

@pescobar: looks excellent, but having an easyconfig file that uses this would be nice to have, so we know this is actively tested...

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 27, 2014

easybuilders/easybuild-easyconfigs#781 is a use case for this, so merging this in

thanks @pescobar!

boegel added a commit that referenced this pull request Mar 27, 2014
added glob support in generic makecp block
@boegel boegel merged commit 2efb9e9 into easybuilders:develop Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants