Fix access to unassigned variable when installing Python < 3.9.1 with using sysroot #3686
Merged
boegel merged 3 commits intoeasybuilders:developfrom May 23, 2025
Merged
Conversation
Contributor
Author
|
@boegel is this a candidate for 5.0.1? Excluding the spaces the change is trivial |
8cbf9de to
7b472c0
Compare
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code will crash when the Python version to be installed is less than 3.9.1 as the variable is unbound/unset in that case.
Fix is trivial: Remove the line of the 2nd if as this is the only place where the variable is set
I included 2 other changes suggested by PyLint:
dict.itemsinstead of iterating over keys and then requesting valuesI can remove one or both again but IMO they make sense. At least the former which doesn't has any drawbacks I can see