Skip to content

Fix incorrect glob pattern & use report_test_failure in test step in LLVM easyblock#3695

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Thyre:fix-small-llvm-issues
Apr 9, 2025
Merged

Fix incorrect glob pattern & use report_test_failure in test step in LLVM easyblock#3695
boegel merged 3 commits intoeasybuilders:developfrom
Thyre:fix-small-llvm-issues

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Apr 9, 2025

Cherry-picked from #3675 for EasyBuild 5.0.1

Thyre added 3 commits April 9, 2025 18:23
@Thyre
LLVM: Fix glob pattern when searching for runtime lib path
908a293 
Signed-off-by: Jan André Reuter <[email protected]>
@Thyre
LLVM: Switch to report_test_failure during test_step
3060f80 
Switch to `report_test_failure` so that the build option
`ignore_test_failure` is correctly handled. Previously,
the raised exception would cause EasyBuild to abort,
without a way to work around this easily.

Signed-off-by: Jan André Reuter <[email protected]>
@Thyre
LLVM: Return when checking tests failed
8f883d9 
Do not check for `num_failed > max_failed` when number
of tests could not be extracted. Instead, return.

This avoids a failure when `--ignore-test-failure` is used
and we run into this case.

Signed-off-by: Jan André Reuter <[email protected]>
@boegel boegel changed the title Fix incorrect glob pattern & use report_test_failure in test step in LLVM EasyBlock Fix incorrect glob pattern & use report_test_failure in test step in LLVM easyblock Apr 9, 2025
@boegel boegel added the bug fix label Apr 9, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 9, 2025
boegel
boegel approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 9, 2025

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr3695 LLVM-14.0.3-GCCcore-11.3.0.eb LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb"

@boegel boegel mentioned this pull request Apr 9, 2025
Merged
@boegelbot
Copy link
Copy Markdown

boegelbot commented Apr 9, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3695 EB_ARGS="--installpath /tmp/$USER/pr3695 LLVM-14.0.3-GCCcore-11.3.0.eb LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3695 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6146

Test results coming soon (I hope)...

Details

- notification for comment with ID 2790342176 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot boegelbot mentioned this pull request Apr 9, 2025
Merged
1 task
@boegelbot
Copy link
Copy Markdown

boegelbot commented Apr 9, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-14.0.3-GCCcore-11.3.0.eb
  • SUCCESS LLVM-16.0.6-GCCcore-12.3.0.eb
  • SUCCESS LLVM-18.1.8-GCCcore-13.3.0-minimal.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/30d0a1700377d69adfbd432431dc8684 for a full test report.

@boegel boegel merged commit 08395be into easybuilders:develop Apr 9, 2025
17 checks passed
@Thyre Thyre mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Thyre @boegel @boegelbot