Skip to content

fix dry run for openssl_wrapper#3719

Merged
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20250514153118_new_pr_openssl_wrapper
May 23, 2025
Merged

fix dry run for openssl_wrapper#3719
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20250514153118_new_pr_openssl_wrapper

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented May 14, 2025 •
edited
Loading

(created using eb --new-pr)

fixes #3718

@branfosj branfosj requested a review from casparvl May 14, 2025 14:31
@branfosj branfosj mentioned this pull request May 14, 2025
Closed
@boegel boegel mentioned this pull request May 14, 2025
Merged
boegel
boegel requested changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj There's one more, see branfosj#1

@branfosj
Merge pull request #1 from boegel/20250514153118_new_pr_openssl_wrapper
30aca89 
also run gcc command to determine system include paths in dry run mode in OpenSSL wrapper easyblock
@boegel boegel added this to the next release (5.0.1 or 5.1.0) milestone May 14, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented May 14, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb
  • SUCCESS OpenSSL-3.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3536.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/eda8e4e4e27e06861b5feda3ae37cc67 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 14, 2025

Hmm, still seeing failures when using -x...

$ eb OpenSSL-1.1.eb OpenSSL-3.eb --include-easyblocks-from-pr 3719 --installpath /tmp/$USER -x
>> Considering 'python3'...
>> 'python3' version: 3.9.18, which matches Python 3 version requirement (>= 3.6)
>> 'python3' is able to import 'easybuild.framework', so retaining it
>> Selected Python command: python3 (/usr/bin/python3)
>> python3 -m easybuild.main OpenSSL-1.1.eb OpenSSL-3.eb --include-easyblocks-from-pr 3719 --installpath /tmp/vsc40023 -x
== Temporary log file in case of crash /tmp/eb-0f63c1bd/easybuild-0w6h3iy4.log
* applying patch file 3719.diff
== easyblock openssl_wrapper.py included from PR #3719
file /tmp/eb-0f63c1bd/fake_vsc_04v4p79u removed

== processing EasyBuild easyconfig /arcanine/scratch/gent/vo/000/gvo00002/vsc40023/easybuild/easybuild-easyconfigs/easybuild/easyconfigs/o/OpenSSL/OpenSSL-1.1.eb

Important note: the actual build & install procedure that will be performed may diverge
(slightly) from what is outlined below, due to conditions in the easyblock which are
incorrectly handled in a dry run.
Any errors that may occur are ignored and reported as warnings, on a per-step basis.
Please be aware of this, and only use the information below for quick debugging purposes.

*** DRY RUN using 'EB_OpenSSL_wrapper' easyblock (easybuild.easyblocks.openssl_wrapper @ /tmp/eb-0f63c1bd/included-easyblocks-ahb8w667/easybuild/easyblocks/openssl_wrapper.py) ***

*** DRY RUN using 'EB_OpenSSL' easyblock (easybuild.easyblocks.openssl @ /arcanine/scratch/gent/vo/000/gvo00002/vsc40023/easybuild/easybuild-easyblocks/easybuild/easyblocks/o/openssl.py) ***

ERROR: Failed to get application instance for OpenSSL (easyblock: EB_OpenSSL_wrapper): Failed to check version of OpenSSL executable: /usr/bin/openssl

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 15, 2025

Hmm, still seeing failures when using -x...

I see the same problem if I run eb OpenSSL-3.eb --include-easyblocks-from-pr 3719 -x. But it works if I already have the updated easyblock locally and run without --include-easyblocks-from-pr 3719.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

@branfosj Ah, thanks for pointing this out, that's a broader known issue, see easybuilders/easybuild-framework#3768, so not a blocker for this fix.

@boegel boegel merged commit a78a255 into easybuilders:develop May 23, 2025
17 checks passed
@branfosj branfosj deleted the 20250514153118_new_pr_openssl_wrapper branch July 18, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@casparvl casparvl Awaiting requested review from casparvl

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

OpenSSL EasyBlock fails in dryrun because it cannot find the OpenSSL version

2 participants

@branfosj @boegel