Skip to content

use --enable-install-libiberty to enable libiberty for binutils#3736

Merged
jfgrimm merged 3 commits intoeasybuilders:developfrom
branfosj:20250523163906_new_pr_binutils
May 28, 2025
Merged

use --enable-install-libiberty to enable libiberty for binutils#3736
jfgrimm merged 3 commits intoeasybuilders:developfrom
branfosj:20250523163906_new_pr_binutils

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented May 23, 2025

(created using eb --new-pr)

@branfosj branfosj mentioned this pull request May 23, 2025
Closed
@Micket Micket added the bug fix label May 23, 2025
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 23, 2025 •
edited
Loading

Marking as draft as this causes the libiberty include files to end up in the subdirectory.

Micket
Micket approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 23, 2025

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.40.eb
  • SUCCESS binutils-2.42.eb
  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb
  • SUCCESS binutils-2.42-GCCcore-14.2.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 9.2, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.9.18
See https://gist.github.com/Micket/635c49d103086ebaa81f6987a78d3c91 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented May 23, 2025

Test report by @Thyre

Overview of tested easyconfigs (in order)

  • SUCCESS zlib-1.3.1-GCCcore-13.3.0.eb
  • SUCCESS zlib-1.3.1-GCCcore-14.2.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-13.3.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-14.2.0.eb
  • SUCCESS M4-1.4.19-GCCcore-13.3.0.eb
  • SUCCESS M4-1.4.19-GCCcore-14.2.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-13.3.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-14.2.0.eb
  • SUCCESS flex-2.6.4-GCCcore-13.3.0.eb
  • SUCCESS flex-2.6.4-GCCcore-14.2.0.eb
  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb
  • SUCCESS binutils-2.42-GCCcore-14.2.0.eb

Build succeeded for 12 out of 12 (3 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 565.57.01, Python 3.10.12
See https://gist.github.com/Thyre/cc95c5fb2af2af91f1b71794a1ea0d66 for a full test report.

@Thyre Thyre mentioned this pull request May 23, 2025
Merged
1 task
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 23, 2025

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 20 out of 25 (25 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/1ea55213bcc6e89f623de8f52f7e444c for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented May 23, 2025

Example EasyConfig to test with: easybuilders/easybuild-easyconfigs#22945

@boegel boegel added this to the release after 5.1.0 milestone May 23, 2025
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 24, 2025

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.32.eb
  • SUCCESS binutils-2.34.eb
  • SUCCESS binutils-2.35.eb
  • SUCCESS binutils-2.37.eb
  • SUCCESS binutils-2.39.eb
  • SUCCESS binutils-2.35-GCCcore-10.2.0.eb
  • SUCCESS binutils-2.37-GCCcore-11.2.0.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb
  • SUCCESS binutils-2.44.eb
  • SUCCESS binutils-2.36.1.eb
  • SUCCESS binutils-2.38.eb
  • SUCCESS binutils-2.40.eb
  • SUCCESS binutils-2.42.eb
  • SUCCESS binutils-2.36.1-GCCcore-10.3.0.eb
  • SUCCESS binutils-2.38-GCCcore-11.3.0.eb
  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb
  • SUCCESS binutils-2.40-GCCcore-12.3.0.eb
  • SUCCESS binutils-2.40-GCCcore-13.1.0.eb
  • SUCCESS binutils-2.42-GCCcore-14.2.0.eb
  • SUCCESS binutils-2.40-GCCcore-13.2.0.eb
  • SUCCESS GCCcore-11.4.0.eb
  • SUCCESS GCCcore-11.1.0.eb
  • SUCCESS GCCcore-12.1.0.eb
  • SUCCESS GCCcore-14.1.0.eb
  • SUCCESS GCCcore-15.1.0.eb
  • SUCCESS zlib-1.2.13-GCCcore-11.4.0.eb
  • SUCCESS zlib-1.2.11-GCCcore-11.1.0.eb
  • SUCCESS zlib-1.2.12-GCCcore-12.1.0.eb
  • SUCCESS zlib-1.3.1-GCCcore-14.1.0.eb
  • SUCCESS zlib-1.3.1-GCCcore-15.1.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-11.4.0.eb
  • SUCCESS help2man-1.48.3-GCCcore-11.1.0.eb
  • SUCCESS help2man-1.49.2-GCCcore-12.1.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-14.1.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-15.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-11.4.0.eb
  • SUCCESS M4-1.4.18-GCCcore-11.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-12.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-14.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-15.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-11.4.0.eb
  • SUCCESS Bison-3.7.6-GCCcore-11.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-12.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-14.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-15.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-11.4.0.eb
  • SUCCESS flex-2.6.4-GCCcore-11.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-12.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-14.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-15.1.0.eb
  • SUCCESS binutils-2.40-GCCcore-11.4.0.eb
  • SUCCESS binutils-2.36.1-GCCcore-11.1.0.eb
  • SUCCESS binutils-2.38-GCCcore-12.1.0.eb
  • SUCCESS binutils-2.42-GCCcore-14.1.0.eb
  • SUCCESS binutils-2.44-GCCcore-15.1.0.eb

Build succeeded for 55 out of 55 (25 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/acdf860b0f35285bebf2e3524ba23219 for a full test report.

@Micket Micket mentioned this pull request May 25, 2025
Merged
1 task
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 27, 2025 •
edited
Loading

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.32.eb
  • SUCCESS binutils-2.34.eb
  • SUCCESS binutils-2.35.eb
  • SUCCESS binutils-2.35-GCCcore-10.2.0.eb
  • SUCCESS binutils-2.36.1.eb
  • SUCCESS binutils-2.36.1-GCCcore-10.3.0.eb
  • SUCCESS binutils-2.37.eb
  • SUCCESS binutils-2.37-GCCcore-11.2.0.eb
  • SUCCESS binutils-2.38.eb
  • SUCCESS binutils-2.38-GCCcore-11.3.0.eb
  • SUCCESS binutils-2.39.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb
  • SUCCESS binutils-2.40.eb
  • SUCCESS binutils-2.40-GCCcore-12.3.0.eb
  • SUCCESS binutils-2.40-GCCcore-13.2.0.eb
  • SUCCESS binutils-2.42.eb
  • SUCCESS binutils-2.42-GCCcore-13.3.0.eb
  • SUCCESS binutils-2.42-GCCcore-14.2.0.eb
  • FAIL (build issue) GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/609905b56754e6eeedcb07c8b46ee8ab)
  • SUCCESS GCCcore-12.1.0.eb
  • SUCCESS GCCcore-11.4.0.eb
  • SUCCESS GCCcore-13.1.0.eb
  • SUCCESS GCCcore-14.1.0.eb
  • FAIL (build issue) zlib-1.2.11-GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/128c51c315c179d470d0cec8aa7df80f)
  • SUCCESS zlib-1.2.12-GCCcore-12.1.0.eb
  • SUCCESS zlib-1.2.13-GCCcore-11.4.0.eb
  • SUCCESS zlib-1.2.13-GCCcore-13.1.0.eb
  • SUCCESS zlib-1.3.1-GCCcore-14.1.0.eb
  • FAIL (build issue) help2man-1.48.3-GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/6550cf650d14d88c5c00d0c1c21c6d92)
  • SUCCESS help2man-1.49.2-GCCcore-12.1.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-11.4.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-13.1.0.eb
  • SUCCESS help2man-1.49.3-GCCcore-14.1.0.eb
  • FAIL (build issue) M4-1.4.18-GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/9694678b14e54243bf512f37559aed59)
  • SUCCESS M4-1.4.19-GCCcore-12.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-11.4.0.eb
  • SUCCESS M4-1.4.19-GCCcore-13.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-14.1.0.eb
  • FAIL (build issue) Bison-3.7.6-GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/85938909a561bad29bd7bba0a424fb8d)
  • SUCCESS Bison-3.8.2-GCCcore-12.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-11.4.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-13.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-14.1.0.eb
  • FAIL (build issue) flex-2.6.4-GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/4195df756047309f9cd34789db24ee50)
  • SUCCESS flex-2.6.4-GCCcore-12.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-11.4.0.eb
  • SUCCESS flex-2.6.4-GCCcore-13.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-14.1.0.eb
  • FAIL (build issue) binutils-2.36.1-GCCcore-11.1.0.eb (partial log available at https://gist.github.com/jfgrimm/2592111377c0eeb3859c0e4e1a139e32)
  • SUCCESS binutils-2.38-GCCcore-12.1.0.eb
  • SUCCESS binutils-2.40-GCCcore-11.4.0.eb
  • SUCCESS binutils-2.40-GCCcore-13.1.0.eb
  • SUCCESS binutils-2.42-GCCcore-14.1.0.eb

Build succeeded for 46 out of 53 (23 easyconfigs in total)
node109.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/85521e87b6701c528bbe848bad94e5b2 for a full test report.

Edit: my GCCcore 11.1 failures look like they're due to an issue with the gnu ftp mirror?

@jfgrimm jfgrimm merged commit 7f18e40 into easybuilders:develop May 28, 2025
17 checks passed
@branfosj branfosj deleted the 20250523163906_new_pr_binutils branch May 28, 2025 08:32
@Thyre Thyre mentioned this pull request Jun 27, 2025
Closed
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Jun 27, 2025

Looks like this can break our symlinks from lib to lib64, as libiberty.a might land in lib64 as the only file.
See #3804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@branfosj @Micket @Thyre @jfgrimm @boegel