Skip to content

Make sure RPATH wrappers shipped via buildenv are world executable#3743

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:permissions_buildenv
May 28, 2025
Merged

Make sure RPATH wrappers shipped via buildenv are world executable#3743
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:permissions_buildenv

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 28, 2025 •
edited
Loading

Rpath wrappers are only executable by the user (by default)

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 28, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="buildenv-default-foss-2023a.eb"

@boegelbot
Copy link
Copy Markdown

boegelbot commented May 28, 2025

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3743 EB_ARGS="buildenv-default-foss-2023a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3743 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6506

Test results coming soon (I hope)...

Details

- notification for comment with ID 2916164854 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented May 28, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS buildenv-default-foss-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/b20168c378c61e0afd1da923184e8de0 for a full test report.

boegel
boegel approved these changes May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label May 28, 2025
@boegel boegel added this to the release after 5.1.0 milestone May 28, 2025
@boegel boegel merged commit 4875615 into easybuilders:develop May 28, 2025
17 checks passed
@ocaisa ocaisa deleted the permissions_buildenv branch June 24, 2025 12:51
@boegel boegel changed the title Make sure rpath wrappers shipped via buildenv are world executable Make sure rpath wrappers shipped via buildenv are world executable Jul 2, 2025
@boegel boegel changed the title Make sure rpath wrappers shipped via buildenv are world executable Make sure RPATH wrappers shipped via buildenv are world executable Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @boegelbot @boegel