update ORCA easyblock for version 6.1.0#3796
Conversation
| * | ||
| """ | ||
| nprocs = self.cfg.parallel | ||
| nprocs = self.cfg.get('parallel', 1) |
There was a problem hiding this comment.
| nprocs = self.cfg.get('parallel', 1) | |
| nprocs = self.cfg.parallel |
| # Version 6.1.0 does not have the CompoundScripts | ||
| if LooseVersion(self.version) == LooseVersion('6.1.0'): | ||
| files_to_copy.extend(['datasets', 'lib']) | ||
| else: | ||
| files_to_copy.extend(['datasets', 'lib', (['CompoundScripts'], 'bin')]) |
There was a problem hiding this comment.
| # Version 6.1.0 does not have the CompoundScripts | |
| if LooseVersion(self.version) == LooseVersion('6.1.0'): | |
| files_to_copy.extend(['datasets', 'lib']) | |
| else: | |
| files_to_copy.extend(['datasets', 'lib', (['CompoundScripts'], 'bin')]) | |
| if LooseVersion(self.version) >= LooseVersion('6.1.0'): | |
| files_to_copy.extend(['datasets', 'lib', (['openCOSMORS'], 'bin')]) | |
| else: | |
| files_to_copy.extend(['datasets', 'lib', (['CompoundScripts', 'openCOSMORS'], 'bin')]) |
| if LooseVersion(self.version) >= LooseVersion('6.0.0'): | ||
| if LooseVersion(self.version) >= LooseVersion('6.1.0'): | ||
| files_to_copy.extend(['datasets', 'lib', (['openCOSMORS'], 'bin')]) | ||
| else: |
There was a problem hiding this comment.
Here the distinction between 6.1.0, 6.0.x and 5.x is lost. There should be an elif here, checking for 6.0.x. The check for greater than 5.0.0 should be after an else as it was before.
|
Test report by @smoors Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @smoors Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Going in, thanks @sassy-crick! |
(created using
eb --new-pr)