Skip to content

stop setting separate_build_dir to True in custom easyblock for CGAL#3837

Merged
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20250714172201_new_pr_cgal
Jul 16, 2025
Merged

stop setting separate_build_dir to True in custom easyblock for CGAL#3837
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20250714172201_new_pr_cgal

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jul 14, 2025

(created using eb --new-pr)

CGAL >= 5 uses CMakeMake easyblock directly, so does not need testing

@branfosj branfosj added this to the release after 5.1.1 milestone Jul 14, 2025
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS CGAL-4.14.3-gompi-2021a.eb
  • SUCCESS CGAL-4.14.3-iimpi-2021a.eb
  • SUCCESS Qt5-5.15.5-GCCcore-11.3.0.eb
  • SUCCESS CGAL-4.14.3-gompi-2022a.eb
  • SUCCESS snappy-1.1.9-GCCcore-11.2.0.eb
  • SUCCESS NSPR-4.32-GCCcore-11.2.0.eb
  • SUCCESS NSS-3.69-GCCcore-11.2.0.eb
  • SUCCESS Qt5-5.15.2-GCCcore-11.2.0.eb
  • SUCCESS CGAL-4.14.3-gompi-2021b.eb

Build succeeded for 9 out of 9 (4 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/a9cfa344bb8dd4e69d1cf6a1a00c14d4 for a full test report.

@Micket Micket merged commit 51e195e into easybuilders:develop Jul 16, 2025
17 checks passed
@branfosj branfosj deleted the 20250714172201_new_pr_cgal branch July 16, 2025 15:13
@boegel boegel changed the title remove default separate_build_dir = True in cgal.py stop setting separate_build_dir to True in custom easyblock for CGAL Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants