Skip to content

Explicitely set OMPT options for LLVM#3853

Merged
Crivella merged 7 commits intoeasybuilders:developfrom
Flamefire:llvm-ompt
Jul 31, 2025
Merged

Explicitely set OMPT options for LLVM#3853
Crivella merged 7 commits intoeasybuilders:developfrom
Flamefire:llvm-ompt

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jul 25, 2025

As discussed here it makes sense to set LIBOMP_OMPT_SUPPORT as that will cause a configure error instead of not building the tools interface with only a small configure message

Additionally also set the related LIBOMPTARGET_OMPT_SUPPORT option

Note that our definition of build_openmp_tools is not that of OPENMP_ENABLE_OMPT_TOOLS but rather matches LIBOMP_OMPT_SUPPORT, see https://github.com/llvm/llvm-project/blob/adb2421202e4014b4986a9f1eb40833dc7ec25ad/openmp/README.rst#optional-features

LIBOMP_OMPT_SUPPORT = ON|OFF
Include support for the OpenMP Tools Interface (OMPT).

option(OPENMP_ENABLE_OMPT_TOOLS "Enable building ompt based tools for OpenMP."

So we enable more than just the interface, but I don't think we should change that.

Question: Should we also explicitely enable the optional OMPT features?

LIBOMP_OMPT_OPTIONAL = ON|OFF
Include support for optional OMPT functionality.

It currently defaults to ON, so we can ignore it.

@Flamefire Flamefire mentioned this pull request Jul 25, 2025
Merged
2 tasks
Flamefire added 3 commits July 29, 2025 12:50
@Flamefire
Fix check for empty LLVM_ENABLE_RUNTIMES arg
83bee90
@Flamefire
Move _configure_* calls below _configure_general_build
e2986d0
@Flamefire
Fix order for positional args
1982cae 
> When defining a keyword argument before variable positional arguments,
> one can end up in having multiple values passed for the aforementioned parameter
> in case the method is called with keyword arguments.
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 29, 2025

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-20.1.5-GCCcore-13.3.0.eb
  • SUCCESS LLVM-19.1.7-GCCcore-13.3.0.eb
  • SUCCESS LLVM-18.1.8-GCCcore-13.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
i7011 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/04978fd259177e7d31383b80f1691474 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 30, 2025

@Crivella would you review this please?

Crivella
Crivella reviewed Jul 30, 2025
View reviewed changes
Comment thread easybuild/easyblocks/l/llvm.py Outdated
Comment thread easybuild/easyblocks/l/llvm.py Outdated
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Jul 30, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0.eb LLVM-19.1.7-GCCcore-13.3.0.eb LLVM-20.1.5-GCCcore-13.3.0.eb --installpath /tmp/$USER/ebpr-3853"
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jul 30, 2025

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3853 EB_ARGS="LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0.eb LLVM-19.1.7-GCCcore-13.3.0.eb LLVM-20.1.5-GCCcore-13.3.0.eb --installpath /tmp/$USER/ebpr-3853" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3853 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7413

Test results coming soon (I hope)...

Details

- notification for comment with ID 3136841522 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jul 30, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-16.0.6-GCCcore-12.3.0.eb
  • SUCCESS LLVM-18.1.8-GCCcore-13.3.0.eb
  • SUCCESS LLVM-19.1.7-GCCcore-13.3.0.eb
  • SUCCESS LLVM-20.1.5-GCCcore-13.3.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/2c6e4a3d7f9483b2f0dbd6aa0dbd8a87 for a full test report.

Crivella
Crivella approved these changes Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crivella Crivella added this to the release after 5.1.1 milestone Jul 31, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Jul 31, 2025

Going in, thanks @Flamefire!

@Crivella Crivella merged commit 316f73d into easybuilders:develop Jul 31, 2025
17 checks passed
@Flamefire Flamefire deleted the llvm-ompt branch July 31, 2025 10:52
@smoors smoors mentioned this pull request Aug 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Crivella Crivella Crivella approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @Crivella @boegelbot @boegel