Skip to content

stop using deprecated verbose option in build step of BLAT easyblock#3858

Merged
laraPPr merged 1 commit intoeasybuilders:developfrom
boegel:20250730090003_new_pr_blat
Jul 30, 2025
Merged

stop using deprecated verbose option in build step of BLAT easyblock#3858
laraPPr merged 1 commit intoeasybuilders:developfrom
boegel:20250730090003_new_pr_blat

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 30, 2025 •
edited
Loading

(created using eb --new-pr)

Fixes installation of BLAT easyconfigs when use of deprecated functionality is not allowed:

ERROR: Installation of BLAT-3.7-GCC-12.3.0.eb failed: "DEPRECATED (since v6.0) functionality used: The 'verbose' parameter to build_step is deprecated and unneeded

@boegel boegel added the bug fix label Jul 30, 2025
@boegel boegel added this to the release after 5.1.1 milestone Jul 30, 2025
@boegel boegel changed the title stop using deprecated 'verbose' option in build step of BLAT easyblock stop using deprecated verbose option in build step of BLAT easyblock Jul 30, 2025
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 30, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="BLAT-3.7-GCC-12.3.0.eb"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jul 30, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3858 EB_ARGS="BLAT-3.7-GCC-12.3.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3858 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7403

Test results coming soon (I hope)...

Details

- notification for comment with ID 3135106285 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jul 30, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS BLAT-3.7-GCC-12.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/f5fd74d19984490043544d574a5ca006 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 30, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS BLAT-3.7-GCC-13.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3541.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/626f256ee18898923dd769b271710ca2 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 30, 2025 •
edited
Loading

Duplicate of #3856?

@branfosj branfosj marked this as a duplicate of #3856 Jul 30, 2025
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 30, 2025

Duplicate of #3856?

Yes, but I think the approach I'm using here with *args and **kwargs is better, more forward-looking.

So I would like to see this merged, and then we can update #3856 accordingly for the other easyblocks being touched there (GHC, SCons), and perhaps also tackle the other relevant easyblocks that use the verbose option (Trilinos, NWChem).

laraPPr
laraPPr approved these changes Jul 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Jul 30, 2025

Going in, thanks @boegel!

@laraPPr laraPPr merged commit d3c548b into easybuilders:develop Jul 30, 2025
17 checks passed
@boegel boegel deleted the 20250730090003_new_pr_blat branch July 30, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laraPPr laraPPr laraPPr approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @branfosj @laraPPr