add generic ROCmComponent easyblock to build & install ROCm components#3861
Conversation
Signed-off-by: Jan André Reuter <[email protected]>
|
@Thyre Seems like this should be a generic easyblock instead, since it's not specific to one single software package, but will cover a whole group? |
Yeah, I agree. I wasn't really sure initially where to place it, so I left it there for now. I'll move it to the generic ones. As you've guessed, this can be used for most ROCm components. |
Signed-off-by: Jan André Reuter <[email protected]>
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 1 min 50 secs) (1 easyconfigs in total) |
…ew_pr_rocmcomponent
Signed-off-by: Jan André Reuter <[email protected]>
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (total: 54 secs) (3 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 45 secs) (1 easyconfigs in total) |
|
Succesful test report using this easyblock here, for 10 builds that use this. |
Co-authored-by: Caspar van Leeuwen <[email protected]>
Co-authored-by: Caspar van Leeuwen <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
…ew_pr_rocmcomponent
|
Old style EasyConfig with Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 1 min 36 secs) (1 easyconfigs in total) |
Signed-off-by: Jan André Reuter <[email protected]>
|
The test correctly uses Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (total: 39 secs) (1 easyconfigs in total) |
Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
Add CMAKE_IGNORE_PATH flag to generic `rocmcomponent` easyblock
|
This EasyBlock has a lot of succesful test reports for cross-compilation: 25 easyconfigs from easybuilders/easybuild-easyconfigs#25576 (comment) (with the one failing one being fixed and retested at easybuilders/easybuild-easyconfigs#25576 (comment) A test build is currently running on jsc-zen3 easybuilders/easybuild-easyconfigs#25576 (comment) . I'll do builds on a system with a native MI210 soon (hopefully tonight) using that same EasyConfigs PR. If that all succeds then, together with the test builds in which @Thyre already tested specific functionality, I think that's sufficient. This is all new functionality after all - it won't break anything existing for anyone. And I'd really like the unit tests on easybuilders/easybuild-easyconfigs#25576 to no longer complain about the missing easyblock, so we can clean up any remaining issues with unit tests there. |
There was a problem hiding this comment.
We've done a ton of testing with EasyConfigs from easybuilders/easybuild-easyconfigs#25576 . By now, we only see issues there related to the easyconfigs themselves, which makes me confident that this easyblock does what it is supposed to do.
Thanks @Thyre
ROCmComponent easyblock to build & install ROCm components
(created using
eb --new-pr)This is a draft EasyBlock supporting the build of ROCm components by unifying similar config options into one EasyBlock on top of CMakeMake.
A few things can be cleaned up, e.g. using
list_to_cmake_argof the CMakeMake EasyBlock, now that this has been integrated.ROCm components will slowly be added in EasyConfig PRs, with one example being easybuilders/easybuild-easyconfigs#23542, which can benefit significantly.