Skip to content

Accept arguments for sanity_check_step in HPL easyblock#3904

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:hpl-fix
Sep 10, 2025
Merged

Accept arguments for sanity_check_step in HPL easyblock#3904
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:hpl-fix

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Aug 28, 2025

Only accept kwargs though such that custom_paths cannot be passed twice (via positional args)

Fixes #3889

cc @Micket

@Flamefire
Accept arguments for sanity_check_step in HPL easyblock
9ce7f6d 
Only accept kwargs though such that custom_paths cannot be passed twice
(via positional args)

Fixes easybuilders#3889
@boegel boegel added the bug fix label Sep 10, 2025
@boegel boegel added this to the next release (5.1.2) milestone Sep 10, 2025
boegel
boegel approved these changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Accept arguments for sanity_check_step in HPL easyblock Accept arguments for sanity_check_step in HPL easyblock Sep 10, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="HPCC-1.5.0-foss-2022a.eb HPL-2.3-foss-2025a.eb"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 10, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3904 EB_ARGS="HPCC-1.5.0-foss-2022a.eb HPL-2.3-foss-2025a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3904 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7915

Test results coming soon (I hope)...

Details

- notification for comment with ID 3274125616 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Sep 10, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS HPCC-1.5.0-foss-2022a.eb
  • SUCCESS HPL-2.3-foss-2025a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/96c74a64ab4d3f66be458b479dda3188 for a full test report.

@boegel boegel merged commit 59fa0db into easybuilders:develop Sep 10, 2025
17 checks passed
@Flamefire Flamefire deleted the hpl-fix branch September 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

HPCC easyblock is broken after changing to super() call, since it intentioanlly used to skip the HPL checks

3 participants

@Flamefire @boegel @boegelbot