Skip to content

use clean_dir instead of remove_dir on installation directory in custom easyblock for Go#3931

Merged
boegel merged 1 commit intoeasybuilders:developfrom
smoors:20250915153914_new_pr_go
Apr 8, 2026
Merged

use clean_dir instead of remove_dir on installation directory in custom easyblock for Go#3931
boegel merged 1 commit intoeasybuilders:developfrom
smoors:20250915153914_new_pr_go

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Sep 15, 2025 •
edited by boegel
Loading

@smoors smoors mentioned this pull request Sep 15, 2025
Closed
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Sep 17, 2025

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS Go-1.22.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node604.hydra.os - Linux Rocky Linux 9.6, x86_64, AMD EPYC 9384X 32-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/smoors/845d7df924bce2cb5ec58d0f3742df80 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Sep 17, 2025

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS Go-1.23.6.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node604.hydra.os - Linux Rocky Linux 9.6, x86_64, AMD EPYC 9384X 32-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/smoors/2f8439dd6ff560593b1fc8803f8490ef for a full test report.

@smoors smoors mentioned this pull request Feb 20, 2026
Merged
@boegel boegel changed the title use clean_dir instead of remove_dir on installation directory for Go easyblock use clean_dir instead of remove_dir on installation directory for Go easyblock Mar 19, 2026
@boegel boegel added this to the next release (5.2.2?) milestone Mar 19, 2026
boegel
boegel approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title use clean_dir instead of remove_dir on installation directory for Go easyblock use clean_dir instead of remove_dir on installation directory in custom easyblock for Go Mar 19, 2026
@easybuilders easybuilders deleted a comment from boegelbot Apr 8, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 8, 2026

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/boegelbot/pr3931 Go-1.16.3.eb Go-1.21.6.eb Go-1.25.7.eb"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Apr 8, 2026

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3931 EB_ARGS="--installpath /tmp/boegelbot/pr3931 Go-1.16.3.eb Go-1.21.6.eb Go-1.25.7.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3931 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10160

Test results coming soon (I hope)...

Details

- notification for comment with ID 4205894283 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Apr 8, 2026

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Go-1.16.3.eb

  • SUCCESS Go-1.21.6.eb

  • SUCCESS Go-1.25.7.eb

Build succeeded for 3 out of 3 (total: 2 mins 44 secs) (3 easyconfigs in total)
jsczen3c3.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/e4c9dac5b152029664e4f6f4bb963f1c for a full test report.

@boegel boegel merged commit 1b5dda4 into easybuilders:develop Apr 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@smoors @boegel @boegelbot