Skip to content

fix custom easyblock for bzip2 to ensure all versioned symlinks are created#3948

Merged
boegel merged 2 commits intoeasybuilders:developfrom
jfgrimm:20251002155038_new_pr_bzip2
Oct 22, 2025
Merged

fix custom easyblock for bzip2 to ensure all versioned symlinks are created#3948
boegel merged 2 commits intoeasybuilders:developfrom
jfgrimm:20251002155038_new_pr_bzip2

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Oct 2, 2025 •
edited
Loading

got some software explicitly linking libbz.so.1, the symlink for which we don't create (so it ended up using the OS bzip2 instead)

(created using eb --new-pr)

@boegel boegel added the bug fix label Oct 8, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Oct 8, 2025
Thyre
Thyre reviewed Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Thyre Thyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, just needs some tests 😄

Comment thread easybuild/easyblocks/b/bzip2.py
def sanity_check_step(self):
"""Custom sanity check for bzip2."""
libs = ['lib/libbz2.a']
if self.cfg['with_shared_libs']:
Copy link
Copy Markdown
Collaborator

@Thyre Thyre Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a sanity check for the unversioned symlinks as well?

Copy link
Copy Markdown
Member

@boegel boegel Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already done, we're already checking for lib/libbz2.so

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Oct 13, 2025 •
edited
Loading

Test report by @Thyre

Overview of tested easyconfigs (in order)

  • SUCCESS bzip2-1.0.8-GCCcore-14.2.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-14.3.0.eb
  • SUCCESS bzip2-1.0.8.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor (zen4), 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: Linuxversion6.17.1-arch1-1(linux@archlinux)(gcc(GCC)15.2.120250813,GNUld(GNUBinutils)2.45.0)#1SMPPREEMPT_DYNAMICMon,06Oct202518:48:29+0000), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: Linuxversion6.17.1-arch1-1(linux@archlinux)(gcc(GCC)15.2.120250813,GNUld(GNUBinutils)2.45.0)#1SMPPREEMPT_DYNAMICMon,06Oct202518:48:29+0000), Python 3.13.7
See https://gist.github.com/Thyre/30cb72d5ff099e930dece6cac0119f1c for a full test report.

Before:

$ ls -lah $EBROOTBZIP2/lib
total 556K
drwxr-xr-x 3 jreuter jreuter 4,0K 13. Okt 16:38 .
drwxr-xr-x 7 jreuter jreuter 4,0K 13. Okt 16:38 ..
-rw-r--r-- 1 jreuter jreuter 265K 13. Okt 16:38 libbz2.a
lrwxrwxrwx 1 jreuter jreuter   15 13. Okt 16:38 libbz2.so -> libbz2.so.1.0.8
lrwxrwxrwx 1 jreuter jreuter   15 13. Okt 16:38 libbz2.so.1.0 -> libbz2.so.1.0.8
-rwxr-xr-x 1 jreuter jreuter 273K 13. Okt 16:38 libbz2.so.1.0.8
drwxr-xr-x 2 jreuter jreuter 4,0K 13. Okt 16:38 pkgconfig

After:

$ ls -lah $EBROOTBZIP2/lib
total 556K
drwxr-xr-x 3 jreuter jreuter 4,0K 13. Okt 16:36 .
drwxr-xr-x 7 jreuter jreuter 4,0K 13. Okt 16:36 ..
-rw-r--r-- 1 jreuter jreuter 265K 13. Okt 16:36 libbz2.a
lrwxrwxrwx 1 jreuter jreuter   15 13. Okt 16:36 libbz2.so -> libbz2.so.1.0.8
lrwxrwxrwx 1 jreuter jreuter   15 13. Okt 16:36 libbz2.so.1 -> libbz2.so.1.0.8
lrwxrwxrwx 1 jreuter jreuter   15 13. Okt 16:36 libbz2.so.1.0 -> libbz2.so.1.0.8
-rwxr-xr-x 1 jreuter jreuter 273K 13. Okt 16:36 libbz2.so.1.0.8
drwxr-xr-x 2 jreuter jreuter 4,0K 13. Okt 16:36 pkgconfig

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Oct 13, 2025

Test report by @Thyre

Overview of tested easyconfigs (in order)

  • SUCCESS bzip2-1.0.8-GCCcore-13.3.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-14.2.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-14.3.0.eb
  • SUCCESS zlib-1.2.11.eb
  • SUCCESS binutils-2.37.eb
  • SUCCESS bzip2-1.0.8.eb

Build succeeded for 6 out of 6 (4 easyconfigs in total)
ZAM054 - Linux Zorin OS 17, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, 1 x NVIDIA NVIDIA GeForce MX550, 580.65.06, Python 3.10.12
See https://gist.github.com/Thyre/cd28e1fa05c8fec14fcbee03b95ad28e for a full test report.

boegel
boegel approved these changes Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title ensure all versioned symlinks are created for bzip2 fix custom easyblock for bzip2 to ensure all versioned symlinks are created for bzip2 Oct 22, 2025
@boegel boegel changed the title fix custom easyblock for bzip2 to ensure all versioned symlinks are created for bzip2 fix custom easyblock for bzip2 to ensure all versioned symlinks are created Oct 22, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 22, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS bzip2-1.0.8.eb
  • SUCCESS bzip2-1.0.8-GCCcore-11.2.0.eb
  • SUCCESS bzip2-1.0.8-GCCcore-14.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node4205.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/47c1c9edf0f3ca191ec39bf2361e7701 for a full test report.

@boegel boegel merged commit 3c3bde2 into easybuilders:develop Oct 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

+1 more reviewer

@Thyre Thyre Thyre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfgrimm @Thyre @boegel