Skip to content

disable extra source dirs requirement for GCC versions older than 4.5#400

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:old_gcc
Apr 30, 2014
Merged

disable extra source dirs requirement for GCC versions older than 4.5#400
boegel merged 3 commits intoeasybuilders:developfrom
boegel:old_gcc

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 24, 2014

although the diff is big, only a couple of lines of code are added (the version check on 4.5 on top, and the else part at the bottom), the remainder is indentation

this is required for GCC versions prior to 4.5 (PR with easyconfigs coming up)

Comment thread easybuild/easyblocks/g/gcc.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 blank lines?

@wpoely86
Copy link
Copy Markdown
Member

@boegel seems fine to me!

@wpoely86
Copy link
Copy Markdown
Member

Will collide with #396

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 30, 2014

@wpoely86: fixed the minor remark

I'll merge this, and issue a PR to your branch to fix the merge conflict w.r.t. #396

boegel added a commit that referenced this pull request Apr 30, 2014
disable extra source dirs requirement for GCC versions older than 4.5
@boegel boegel merged commit 915f818 into easybuilders:develop Apr 30, 2014
@boegel boegel deleted the old_gcc branch May 5, 2014 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants