Skip to content

allow oversubscription in sanity check for OpenFOAM#4019

Merged
boegel merged 1 commit intoeasybuilders:developfrom
smoors:20251213180036_new_pr_openfoam
Jan 14, 2026
Merged

allow oversubscription in sanity check for OpenFOAM#4019
boegel merged 1 commit intoeasybuilders:developfrom
smoors:20251213180036_new_pr_openfoam

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Dec 13, 2025 •
edited
Loading

(created using eb --new-pr)

the number of processes used for the motorBike sanity is hardcoded (6 for older versions, 8 for newer versions of the .org version), which fails if the number of cores is less.

this PR fixes it for OpenMPI by allowing oversubscription.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Dec 13, 2025

Test report by @smoors

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-13-foss-2025a.eb

Build succeeded for 1 out of 1 (total: 34 secs) (1 easyconfigs in total)
node700.hydra.os - Linux Rocky Linux 9.6, x86_64, AMD EPYC 9535 64-Core Processor (zen5), Python 3.9.21
See https://gist.github.com/smoors/ad9a0df725288eba17b392b14430b479 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Dec 13, 2025

@boegelbot please test @ jsc-zen3
CORE_CNT=4 EB_ARGS="OpenFOAM-13-foss-2025a.eb OpenFOAM-10-foss-2023a.eb --sanity-check-only"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Dec 13, 2025

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4019 EB_ARGS="OpenFOAM-13-foss-2025a.eb OpenFOAM-10-foss-2023a.eb --sanity-check-only" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4019 --ntasks="4" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9120

Test results coming soon (I hope)...

Details

- notification for comment with ID 3649630599 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Dec 13, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-13-foss-2025a.eb

  • SUCCESS OpenFOAM-10-foss-2023a.eb

Build succeeded for 2 out of 2 (total: 7 mins 52 secs) (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/cea59282bca89fd583314a21cd6b9003 for a full test report.

@smoors smoors changed the title allow oversubscription in sanity check for openfoam allow oversubscription in sanity check for OpenFOAM Dec 19, 2025
@boegel boegel added this to the next release (5.2.1?) milestone Jan 14, 2026
boegel
boegel approved these changes Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit c2ad8e7 into easybuilders:develop Jan 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@smoors @boegelbot @boegel