Skip to content

Fix missed sanity check in custom easyblock for GCC#4041

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20260114174629_new_pr_gcc
Jan 28, 2026
Merged

Fix missed sanity check in custom easyblock for GCC#4041
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20260114174629_new_pr_gcc

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jan 14, 2026 •
edited
Loading

(created using eb --new-pr)

Main change is in line 1146:

-            ["libgomp.%s" % sharedlib_ext, "libgomp.a"]
+            lib_files.extend(["libgomp.%s" % sharedlib_ext, "libgomp.a"])

I.e. we created a list but did nothing with it

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jan 14, 2026

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS GCCcore-13.2.0.eb

Build succeeded for 1 out of 1 (total: 31 mins 44 secs) (1 easyconfigs in total)
n1375.barnard.hpc.tu-dresden.de - Linux RHEL 9.6, x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.21
See https://gist.github.com/Flamefire/68a1bdc8d8bb6284c66287d55e7ac5a8 for a full test report.

@Thyre Thyre added the bug fix label Jan 19, 2026
@boegel boegel added this to the next release (5.2.1?) milestone Jan 28, 2026
boegel
boegel approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix missed sanity check in GCC Fix missed sanity check in custom easyblock for GCC Jan 28, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 28, 2026

@boegelbot please test @ jsc-zen3
EB_ARGS="GCCcore-11.2.0.eb GCCcore-11.3.0.eb GCCcore-11.4.0.eb GCCcore-12.1.0.eb GCCcore-12.2.0.eb GCCcore-12.3.0.eb GCCcore-13.1.0.eb GCCcore-13.2.0.eb GCCcore-13.3.0.eb GCCcore-14.1.0.eb GCCcore-14.2.0.eb GCCcore-14.3.0.eb GCCcore-15.1.0.eb GCCcore-15.2.0.eb --sanity-check-only"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 28, 2026

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4041 EB_ARGS="GCCcore-11.2.0.eb GCCcore-11.3.0.eb GCCcore-11.4.0.eb GCCcore-12.1.0.eb GCCcore-12.2.0.eb GCCcore-12.3.0.eb GCCcore-13.1.0.eb GCCcore-13.2.0.eb GCCcore-13.3.0.eb GCCcore-14.1.0.eb GCCcore-14.2.0.eb GCCcore-14.3.0.eb GCCcore-15.1.0.eb GCCcore-15.2.0.eb --sanity-check-only" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4041 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9512

Test results coming soon (I hope)...

Details

- notification for comment with ID 3809911952 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Jan 28, 2026

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS GCCcore-11.2.0.eb

  • SUCCESS GCCcore-11.3.0.eb

  • SUCCESS GCCcore-11.4.0.eb

  • SUCCESS GCCcore-12.1.0.eb

  • SUCCESS GCCcore-12.2.0.eb

  • SUCCESS GCCcore-12.3.0.eb

  • SUCCESS GCCcore-13.1.0.eb

  • SUCCESS GCCcore-13.2.0.eb

  • SUCCESS GCCcore-13.3.0.eb

  • SUCCESS GCCcore-14.1.0.eb

  • SUCCESS GCCcore-14.2.0.eb

  • SUCCESS GCCcore-14.3.0.eb

  • SUCCESS GCCcore-15.1.0.eb

  • SUCCESS GCCcore-15.2.0.eb

Build succeeded for 14 out of 14 (total: 2 mins 41 secs) (14 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/1bd3c633f18264ba5eb70e1f7abd30d4 for a full test report.

@boegel boegel merged commit f8be5f2 into easybuilders:develop Jan 28, 2026
22 checks passed
@Flamefire Flamefire deleted the 20260114174629_new_pr_gcc branch February 1, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @boegel @boegelbot @Thyre