Skip to content

Fix limiting of threads for OpenBLAS tests#4067

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:20260217144746_new_pr_openblas
Feb 17, 2026
Merged

Fix limiting of threads for OpenBLAS tests#4067
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:20260217144746_new_pr_openblas

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

Thyre
Thyre previously requested changes Feb 17, 2026
Copy link
Copy Markdown
Collaborator

@Thyre Thyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should ensure that we don't produce a broken command when a user e.g. sets pretestopts to export ABC="def".

Comment thread easybuild/easyblocks/o/openblas.py Outdated
Comment thread easybuild/easyblocks/o/openblas.py Outdated
@Thyre Thyre added the bug fix label Feb 17, 2026
@Thyre Thyre added this to the release after 5.2.1 milestone Feb 17, 2026
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix limitting of threads for OpenBLAS tests Fix limiting of threads for OpenBLAS tests Feb 17, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 17, 2026

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenBLAS-0.3.23-GCC-12.3.0.eb

  • SUCCESS OpenBLAS-0.3.30-llvm-compilers-20.1.8.eb

  • SUCCESS OpenBLAS-0.3.31-GCC-15.2.0.eb

Build succeeded for 3 out of 3 (total: 1 hour 48 mins 43 secs) (3 easyconfigs in total)
node4414.skiddo.os - Linux RHEL 9.6, x86_64, AMD EPYC 9755 128-Core Processor (zen5), Python 3.9.21
See https://gist.github.com/boegel/43c6229945718730c9b9efdf01c5719b for a full test report.

@boegel boegel dismissed Thyre’s stale review February 17, 2026 17:19

requested changes made

@boegel boegel merged commit 765d75f into easybuilders:develop Feb 17, 2026
22 checks passed
@Flamefire Flamefire deleted the 20260217144746_new_pr_openblas branch February 18, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants